* Re: [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency
[not found] <20251027-mips_paralell_hotplug-v1-1-01b6cd13ee85@bootlin.com>
@ 2025-11-10 14:05 ` Gregory CLEMENT
2025-11-10 14:37 ` Thomas Bogendoerfer
0 siblings, 1 reply; 5+ messages in thread
From: Gregory CLEMENT @ 2025-11-10 14:05 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Benoît Monin, Théo Lebrun, Vladimir Kondratiev,
Thomas Petazzoni, linux-mips, linux-kernel, kernel test robot
Hello Thomas,
> With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
> selected. However, in kernel/cpu.c, some code that uses
> HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
> we should fix the HOTPLUG_PARALLEL dependency to depend on
> HOTPLUG_CPU, not just SMP.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Do you have any comments about this fix?
Regards,
Gregory
> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index e8683f58fd3e2..b88b97139fa8e 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -658,7 +658,7 @@ config EYEQ
> select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> select USE_OF
> - select HOTPLUG_PARALLEL if SMP
> + select HOTPLUG_PARALLEL if HOTPLUG_CPU
> help
> Select this to build a kernel supporting EyeQ SoC from Mobileye.
>
>
> ---
> base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
> change-id: 20251027-mips_paralell_hotplug-e9ae2b1fa126
>
> Best regards,
> --
> Grégory CLEMENT, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency
2025-11-10 14:05 ` [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency Gregory CLEMENT
@ 2025-11-10 14:37 ` Thomas Bogendoerfer
2025-11-14 15:52 ` Gregory CLEMENT
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Bogendoerfer @ 2025-11-10 14:37 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Benoît Monin, Théo Lebrun, Vladimir Kondratiev,
Thomas Petazzoni, linux-mips, linux-kernel, kernel test robot
On Mon, Nov 10, 2025 at 03:05:23PM +0100, Gregory CLEMENT wrote:
> Hello Thomas,
>
> > With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
> > selected. However, in kernel/cpu.c, some code that uses
> > HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
> > we should fix the HOTPLUG_PARALLEL dependency to depend on
> > HOTPLUG_CPU, not just SMP.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
> > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>
> Do you have any comments about this fix?
all good from my side, does it need to go via mips-fixes ?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency
2025-11-10 14:37 ` Thomas Bogendoerfer
@ 2025-11-14 15:52 ` Gregory CLEMENT
0 siblings, 0 replies; 5+ messages in thread
From: Gregory CLEMENT @ 2025-11-14 15:52 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Benoît Monin, Théo Lebrun, Vladimir Kondratiev,
Thomas Petazzoni, linux-mips, linux-kernel, kernel test robot
Thomas Bogendoerfer <tsbogend@alpha.franken.de> writes:
> On Mon, Nov 10, 2025 at 03:05:23PM +0100, Gregory CLEMENT wrote:
>> Hello Thomas,
>>
>> > With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
>> > selected. However, in kernel/cpu.c, some code that uses
>> > HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
>> > we should fix the HOTPLUG_PARALLEL dependency to depend on
>> > HOTPLUG_CPU, not just SMP.
>> >
>> > Reported-by: kernel test robot <lkp@intel.com>
>> > Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
>> > Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
>>
>> Do you have any comments about this fix?
>
> all good from my side, does it need to go via mips-fixes ?
This fixes a build failure that occurs only in unusual kernel
configurations, so from my point of view, it is not critical.
Gregory
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency
@ 2025-10-27 16:15 Gregory CLEMENT
2025-12-01 9:41 ` Thomas Bogendoerfer
0 siblings, 1 reply; 5+ messages in thread
From: Gregory CLEMENT @ 2025-10-27 16:15 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Benoît Monin, Théo Lebrun, Vladimir Kondratiev,
Thomas Petazzoni, linux-mips, linux-kernel, kernel test robot,
Gregory CLEMENT
With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
selected. However, in kernel/cpu.c, some code that uses
HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
we should fix the HOTPLUG_PARALLEL dependency to depend on
HOTPLUG_CPU, not just SMP.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
arch/mips/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index e8683f58fd3e2..b88b97139fa8e 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -658,7 +658,7 @@ config EYEQ
select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
select USE_OF
- select HOTPLUG_PARALLEL if SMP
+ select HOTPLUG_PARALLEL if HOTPLUG_CPU
help
Select this to build a kernel supporting EyeQ SoC from Mobileye.
---
base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
change-id: 20251027-mips_paralell_hotplug-e9ae2b1fa126
Best regards,
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency
2025-10-27 16:15 Gregory CLEMENT
@ 2025-12-01 9:41 ` Thomas Bogendoerfer
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Bogendoerfer @ 2025-12-01 9:41 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Benoît Monin, Théo Lebrun, Vladimir Kondratiev,
Thomas Petazzoni, linux-mips, linux-kernel, kernel test robot
On Mon, Oct 27, 2025 at 05:15:35PM +0100, Gregory CLEMENT wrote:
> With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
> selected. However, in kernel/cpu.c, some code that uses
> HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
> we should fix the HOTPLUG_PARALLEL dependency to depend on
> HOTPLUG_CPU, not just SMP.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index e8683f58fd3e2..b88b97139fa8e 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -658,7 +658,7 @@ config EYEQ
> select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> select USE_OF
> - select HOTPLUG_PARALLEL if SMP
> + select HOTPLUG_PARALLEL if HOTPLUG_CPU
> help
> Select this to build a kernel supporting EyeQ SoC from Mobileye.
>
>
> ---
> base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
> change-id: 20251027-mips_paralell_hotplug-e9ae2b1fa126
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-01 9:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251027-mips_paralell_hotplug-v1-1-01b6cd13ee85@bootlin.com>
2025-11-10 14:05 ` [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency Gregory CLEMENT
2025-11-10 14:37 ` Thomas Bogendoerfer
2025-11-14 15:52 ` Gregory CLEMENT
2025-10-27 16:15 Gregory CLEMENT
2025-12-01 9:41 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox