* [PATCH] ALSA: AC97: Use str_on_off() helper in snd_ac97_proc_read_main()
@ 2024-12-28 23:38 Thorsten Blum
2024-12-29 8:25 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-12-28 23:38 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Thorsten Blum, linux-sound, linux-kernel
Remove hard-coded strings by using the str_on_off() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
sound/pci/ac97/ac97_proc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/pci/ac97/ac97_proc.c b/sound/pci/ac97/ac97_proc.c
index 5426f7bc9884..518834964b7b 100644
--- a/sound/pci/ac97/ac97_proc.c
+++ b/sound/pci/ac97/ac97_proc.c
@@ -161,12 +161,12 @@ static void snd_ac97_proc_read_main(struct snd_ac97 *ac97, struct snd_info_buffe
"Mic select : %s\n"
"ADC/DAC loopback : %s\n",
val & 0x8000 ? "post" : "pre",
- val & 0x4000 ? "on" : "off",
- val & 0x2000 ? "on" : "off",
- val & 0x1000 ? "on" : "off",
+ str_on_off(val & 0x4000),
+ str_on_off(val & 0x2000),
+ str_on_off(val & 0x1000),
val & 0x0200 ? "Mic" : "MIX",
val & 0x0100 ? "Mic2" : "Mic1",
- val & 0x0080 ? "on" : "off");
+ str_on_off(val & 0x0080));
if (ac97->ext_id & AC97_EI_DRA)
snd_iprintf(buffer, "Double rate slots: %s\n",
double_rate_slots[(val >> 10) & 3]);
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: AC97: Use str_on_off() helper in snd_ac97_proc_read_main()
2024-12-28 23:38 [PATCH] ALSA: AC97: Use str_on_off() helper in snd_ac97_proc_read_main() Thorsten Blum
@ 2024-12-29 8:25 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-12-29 8:25 UTC (permalink / raw)
To: Thorsten Blum; +Cc: Jaroslav Kysela, Takashi Iwai, linux-sound, linux-kernel
On Sun, 29 Dec 2024 00:38:48 +0100,
Thorsten Blum wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-29 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-28 23:38 [PATCH] ALSA: AC97: Use str_on_off() helper in snd_ac97_proc_read_main() Thorsten Blum
2024-12-29 8:25 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox