* [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp()
@ 2024-08-23 2:36 Yuesong Li
2024-08-23 8:24 ` Jani Nikula
2024-09-16 9:27 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: Yuesong Li @ 2024-08-23 2:36 UTC (permalink / raw)
To: jani.nikula, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
daniel
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, opensource.kernel,
Yuesong Li
cocci report a double assignment warning. 'as_sdp->duration_incr_ms'
was assigned twice in intel_dp_compute_as_sdp().
Signed-off-by: Yuesong Li <liyuesong@vivo.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 6a0c7ae654f4..229c87be4402 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2730,7 +2730,6 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC;
as_sdp->length = 0x9;
as_sdp->duration_incr_ms = 0;
- as_sdp->duration_incr_ms = 0;
if (crtc_state->cmrr.enable) {
as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp()
2024-08-23 2:36 [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp() Yuesong Li
@ 2024-08-23 8:24 ` Jani Nikula
2024-09-16 9:27 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2024-08-23 8:24 UTC (permalink / raw)
To: Yuesong Li, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
daniel
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, opensource.kernel,
Yuesong Li
On Fri, 23 Aug 2024, Yuesong Li <liyuesong@vivo.com> wrote:
> cocci report a double assignment warning. 'as_sdp->duration_incr_ms'
> was assigned twice in intel_dp_compute_as_sdp().
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 6a0c7ae654f4..229c87be4402 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2730,7 +2730,6 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
> as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC;
> as_sdp->length = 0x9;
> as_sdp->duration_incr_ms = 0;
> - as_sdp->duration_incr_ms = 0;
>
> if (crtc_state->cmrr.enable) {
> as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED;
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp()
2024-08-23 2:36 [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp() Yuesong Li
2024-08-23 8:24 ` Jani Nikula
@ 2024-09-16 9:27 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2024-09-16 9:27 UTC (permalink / raw)
To: Yuesong Li
Cc: jani.nikula, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
daniel, intel-gfx, intel-xe, dri-devel, linux-kernel,
opensource.kernel
Hi Yuesong,
On Fri, Aug 23, 2024 at 10:36:12AM GMT, Yuesong Li wrote:
> cocci report a double assignment warning. 'as_sdp->duration_incr_ms'
> was assigned twice in intel_dp_compute_as_sdp().
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
reviewed and merged to drm-intel-next.
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-16 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-23 2:36 [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp() Yuesong Li
2024-08-23 8:24 ` Jani Nikula
2024-09-16 9:27 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox