* [PATCH] mtd: rawnand: realtek: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 12:30 Pengpeng Hou
2026-07-06 14:09 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-07-04 12:30 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: Pengpeng Hou, linux-mtd, linux-kernel
The driver has an OF match table wired to .of_match_table, but does
not export the table with MODULE_DEVICE_TABLE().
Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
information is generated for OF based module autoloading.
This is a source-level fix. It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the platform driver, and the missing module alias publication.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/mtd/nand/ecc-realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/ecc-realtek.c b/drivers/mtd/nand/ecc-realtek.c
index 7d003fd72027..76d75e2107df 100644
--- a/drivers/mtd/nand/ecc-realtek.c
+++ b/drivers/mtd/nand/ecc-realtek.c
@@ -450,6 +450,7 @@ static const struct of_device_id rtl_ecc_of_ids[] = {
},
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, rtl_ecc_of_ids);
static struct platform_driver rtl_ecc_driver = {
.driver = {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: rawnand: realtek: add missing MODULE_DEVICE_TABLE()
2026-07-04 12:30 [PATCH] mtd: rawnand: realtek: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-06 14:09 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2026-07-06 14:09 UTC (permalink / raw)
To: Pengpeng Hou
Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel
Hi Pengpeng,
On 04/07/2026 at 20:30:44 +08, Pengpeng Hou <pengpeng@iscas.ac.cn> wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
Why do you never add any Fixes and Cc stable tags? This is a behavioural
fix, which probably deserves to be backported. It is the third or even
maybe fourth time that I have to ask for those tags within 2
weeks. Please consider adding them proactively when relevant.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-06 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 12:30 [PATCH] mtd: rawnand: realtek: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-06 14:09 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox