From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Nicolas Pitre <nico@linaro.org>
Subject: Re: [RFC PATCH 1/2] memremap: add arch specific hook for MEMREMAP_WB mappings
Date: Tue, 23 Feb 2016 23:23:42 +0100 [thread overview]
Message-ID: <87twkzukup.fsf@belgarion.home> (raw)
In-Reply-To: <CAPcyv4h86uzieFV4HM-tZoWSVZ7GY2GKEUk334J+5sD_GyzWKg@mail.gmail.com> (Dan Williams's message of "Tue, 23 Feb 2016 09:21:44 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
> On Tue, Feb 23, 2016 at 4:26 AM, Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
>> On 23 February 2016 at 13:03, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>> On 23 February 2016 at 12:58, Russell King - ARM Linux
>>> <linux@arm.linux.org.uk> wrote:
>>>> On Mon, Feb 22, 2016 at 09:35:24PM +0100, Ard Biesheuvel wrote:
>> OK, I see what you mean. I find it unfortunate that ioremap_cache()
>> instances are blindly being replaced with memremap(), and I wonder if
>> this wasted test by and/or cc'ed to people who can actually test this
>> driver. Dan?
Actually I have the hardware to test it.
And I also know what is behind :
- it's a CFI NOR based memory
- these are Intel StrataFlash 28F128J3A chips
- as a CFI memory it is mapped on the system bus
- from a read perspective, it behaves like a normal memory
- but once the first write reaches the CFI, everything changes (the address
space layout doesn't have the same meaning, be that becoming a status code or
something else).
In these conditions reordering of writes versus reads, merging reads after
a write or coalescing writes is a recipe for disaster.
All of this to say I can make a small discrete number of tests (less than 10
write or erase ones to preserve the precious NOR).
Cheers.
--
Robert
next prev parent reply other threads:[~2016-02-23 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 14:02 [RFC PATCH 0/2] fix memremap on ARM Ard Biesheuvel
2016-02-22 14:02 ` [RFC PATCH 1/2] memremap: add arch specific hook for MEMREMAP_WB mappings Ard Biesheuvel
2016-02-22 19:05 ` Dan Williams
2016-02-22 19:17 ` Ard Biesheuvel
2016-02-22 19:55 ` Dan Williams
2016-02-22 20:02 ` Russell King - ARM Linux
2016-02-22 20:35 ` Ard Biesheuvel
2016-02-23 11:58 ` Russell King - ARM Linux
2016-02-23 12:03 ` Ard Biesheuvel
2016-02-23 12:26 ` Ard Biesheuvel
2016-02-23 17:21 ` Dan Williams
2016-02-23 22:23 ` Robert Jarzmik [this message]
2016-02-25 7:49 ` Ard Biesheuvel
2016-02-22 14:02 ` [RFC PATCH 2/2] ARM: memremap: implement arch_memremap_wb() Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twkzukup.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox