[PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio controller

[PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio controller

[Vijendar Mukunda]

Add new pci id for AMD GPU display HD audio controller(device id- 0xab40).

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 512fb22f5e5e..3f8b2bf6eab5 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2715,6 +2715,9 @@ static const struct pci_device_id azx_ids[] = {
 	{ PCI_VDEVICE(ATI, 0xab38),
 	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
 	  AZX_DCAPS_PM_RUNTIME },
+	{ PCI_VDEVICE(ATI, 0xab40),
+	  .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
+	  AZX_DCAPS_PM_RUNTIME },
 	/* GLENFLY */
 	{ PCI_DEVICE(PCI_VENDOR_ID_GLENFLY, PCI_ANY_ID),
 	  .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,
-- 
2.45.2

RE: [PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio controller

[Deucher, Alexander]

[Public]

> -----Original Message-----
> From: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>
> Sent: Thursday, May 29, 2025 1:38 AM
> To: perex@perex.cz; tiwai@suse.com
> Cc: alsa-devel@alsa-project.org; Dommati, Sunil-kumar <Sunil-
> kumar.Dommati@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; linux-sound@vger.kernel.org; linux-
> kernel@vger.kernel.org; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>
> Subject: [PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio
> controller
>
> Add new pci id for AMD GPU display HD audio controller(device id- 0xab40).
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

Is there a way we can just add a default entry for all ATI HDMI HDA endpoints?  It would avoid then need to add an entry every time we release a new endpoint DID.  Either way:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index
> 512fb22f5e5e..3f8b2bf6eab5 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2715,6 +2715,9 @@ static const struct pci_device_id azx_ids[] = {
>       { PCI_VDEVICE(ATI, 0xab38),
>         .driver_data = AZX_DRIVER_ATIHDMI_NS |
> AZX_DCAPS_PRESET_ATI_HDMI_NS |
>         AZX_DCAPS_PM_RUNTIME },
> +     { PCI_VDEVICE(ATI, 0xab40),
> +       .driver_data = AZX_DRIVER_ATIHDMI_NS |
> AZX_DCAPS_PRESET_ATI_HDMI_NS |
> +       AZX_DCAPS_PM_RUNTIME },
>       /* GLENFLY */
>       { PCI_DEVICE(PCI_VENDOR_ID_GLENFLY, PCI_ANY_ID),
>         .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,
> --
> 2.45.2

Re: [PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio controller

[Takashi Iwai]

On Thu, 29 May 2025 07:38:13 +0200,
Vijendar Mukunda wrote:
> 
> Add new pci id for AMD GPU display HD audio controller(device id- 0xab40).
> 
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

Applied now.  Thanks.


Takashi

Re: [PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio controller

[Takashi Iwai]

On Thu, 29 May 2025 22:26:07 +0200,
Deucher, Alexander wrote:
> 
> [Public]
> 
> > -----Original Message-----
> > From: Mukunda, Vijendar <Vijendar.Mukunda@amd.com>
> > Sent: Thursday, May 29, 2025 1:38 AM
> > To: perex@perex.cz; tiwai@suse.com
> > Cc: alsa-devel@alsa-project.org; Dommati, Sunil-kumar <Sunil-
> > kumar.Dommati@amd.com>; Deucher, Alexander
> > <Alexander.Deucher@amd.com>; linux-sound@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Mukunda, Vijendar <Vijendar.Mukunda@amd.com>
> > Subject: [PATCH] ALSA: hda: Add new pci id for AMD GPU display HD audio
> > controller
> >
> > Add new pci id for AMD GPU display HD audio controller(device id- 0xab40).
> >
> > Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> 
> Is there a way we can just add a default entry for all ATI HDMI HDA
> endpoints?  It would avoid then need to add an entry every time we
> release a new endpoint DID.

We have already catch-all entries for ATI and AMD vendors, but those
are setup without AZX_DRIVER_ATIHDMI_NS, that is, for older chip
models.


Takashi