From: Marc Zyngier <maz@kernel.org>
To: Xu Qiang <xuqiang36@huawei.com>
Cc: <tglx@linutronix.de>, <frederic@kernel.org>,
<peterz@infradead.org>, <nitesh@redhat.com>,
<bigeasy@linutronix.de>, <douliyangs@gmail.com>,
<linux-kernel@vger.kernel.org>, <guohanjun@huawei.com>,
<weiyongjun1@huawei.com>
Subject: Re: [PATCH -next 1/3] genirq/affinity: replace managed with is_managed in irq_affinity_desc
Date: Sat, 27 Aug 2022 16:18:48 +0100 [thread overview]
Message-ID: <87v8qdr9yf.wl-maz@kernel.org> (raw)
In-Reply-To: <20220827011351.9185-1-xuqiang36@huawei.com>
On Sat, 27 Aug 2022 02:13:49 +0100,
Xu Qiang <xuqiang36@huawei.com> wrote:
>
> This submission is based on the following two considerations:
>
> 1. The definition of is_managed field is misleading to assume
> that it only uses 1 bit of memory, which is not the case;
You realise that a bitfield is not about the memory used, but the
number of significant bits, right? The memory it uses is the
compiler's business.
> 2. from the actual use of is_managed, it should be a Boolean type;
Why? What is wrong with the existing bitfield? Why renaming it?
>
> Fixes: c410abbbacb9 (“genirq/affinity: Add is_managed to struct irq_affinity_desc”)
I don't see any fix here, only some seemingly pointless bike-shedding.
If you have identified an actual issue, please spell it out for me,
because I cannot see it.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2022-08-27 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 1:13 [PATCH -next 1/3] genirq/affinity: replace managed with is_managed in irq_affinity_desc Xu Qiang
2022-08-27 1:13 ` [PATCH -next 2/3] genirq/affinity: Define tmp_mask as a local variable in irq_do_set_affinity Xu Qiang
2022-08-27 15:24 ` Marc Zyngier
2022-08-27 1:13 ` [PATCH -next 3/3] genirq/affinity: Add __irq_do_set_affinity_lock function Xu Qiang
2022-08-27 15:18 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8qdr9yf.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=douliyangs@gmail.com \
--cc=frederic@kernel.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nitesh@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=weiyongjun1@huawei.com \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox