From: Takashi Iwai <tiwai@suse.de>
To: Abelardo Ricart <aricart@gmail.com>
Cc: linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCHv2] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q
Date: Thu, 21 Sep 2023 09:03:11 +0200 [thread overview]
Message-ID: <87wmwkt3dc.wl-tiwai@suse.de> (raw)
In-Reply-To: <348823a2-af40-42d5-af30-dc00eaf1d90a@gmail.com>
On Thu, 21 Sep 2023 08:58:37 +0200,
Abelardo Ricart wrote:
>
> The same quirk applied to the ASUS G533Z is also applicable to the ASUS
> G533Q (of which I am an owner and have thus tested). Resubmitted for
> e-mail formatting issue.
You don't need to mention about resubmission in the patch description
here. It can be put under the line "---" instead; then it won't be
taken into the git commit log.
In anyway, the problem isn't fixed...
> Signed-off-by: Abelardo Ricart <aricart@gmail.com>
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b7e78bfcffd8..7bb3c1e05bf2 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9781,6 +9781,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V",
> ALC285_FIXUP_ASUS_HEADSET_MIC),
> SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook
> UX31A",ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
> SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V",
> ALC285_FIXUP_ASUS_HEADSET_MIC),
> + SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15
> (G533Q)",ALC285_FIXUP_ASUS_G533Z_PINS),
> SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
> SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR",
> ALC287_FIXUP_CS35L41_I2C_2),
> SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
... now all spaces are gone completely.
Takashi
prev parent reply other threads:[~2023-09-21 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 6:58 [PATCHv2] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q Abelardo Ricart
2023-09-21 7:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmwkt3dc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=aricart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox