From: Michael Ellerman <mpe@ellerman.id.au>
To: Souptick Joarder <jrdr.linux@gmail.com>,
Frederic Barrat <fbarrat@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, fbarrat@linux.vnet.ibm.com,
Matthew Wilcox <willy@infradead.org>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
brajeswar.linux@gmail.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] misc: ocxl: Change return type for fault handler
Date: Tue, 19 Jun 2018 22:57:24 +1000 [thread overview]
Message-ID: <87wouvvsqz.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <CAFqt6zY=rpak3NGUMcCupvLp_RCwLMCtwfnBBjLfSc+U2vQ3OQ@mail.gmail.com>
Souptick Joarder <jrdr.linux@gmail.com> writes:
> On Thu, Jun 14, 2018 at 9:36 PM, Frederic Barrat <fbarrat@linux.ibm.com> wrote:
>> Le 11/06/2018 à 22:29, Souptick Joarder a écrit :
>>>
>>> Use new return type vm_fault_t for fault handler. For
>>> now, this is just documenting that the function returns
>>> a VM_FAULT value rather than an errno. Once all instances
>>> are converted, vm_fault_t will become a distinct type.
>>>
>>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>>
>>> There is an existing bug when vm_insert_pfn() can return
>>> ENOMEM which was ignored and VM_FAULT_NOPAGE returned as
>>> default. The new inline vmf_insert_pfn() has removed
>>> this inefficiency by returning correct vm_fault_ type.
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>> ---
>>
>>
>> Thanks!
>>
>> Tested and
>> Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
>
> Frederic, is this patch queued for 4.19 ?
Not yet, you're a bit early. 4.18-rc1 only came out the other day :)
Your patches are tracked here:
http://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=67924
They should appear in 4.19 unless something conflicts with them.
cheers
next prev parent reply other threads:[~2018-06-19 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 20:29 [PATCH] misc: ocxl: Change return type for fault handler Souptick Joarder
2018-06-12 4:39 ` Andrew Donnellan
2018-06-14 16:06 ` Frederic Barrat
2018-06-19 5:09 ` Souptick Joarder
2018-06-19 12:57 ` Michael Ellerman [this message]
2018-07-11 13:24 ` Michael Ellerman
2018-07-13 12:57 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wouvvsqz.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=arnd@arndb.de \
--cc=brajeswar.linux@gmail.com \
--cc=fbarrat@linux.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sabyasachi.linux@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox