The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Matthew Leach <matthew@mattleach.net>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board
Date: Wed, 11 May 2016 19:18:31 +0100	[thread overview]
Message-ID: <87y47gwj9k.fsf@mattleach.net> (raw)
In-Reply-To: <1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Wed, 11 May 2016 09:06:52 +0200")

Hi Krzysztof,

Sorry for not acting on the feedback sooner - I lost the email in my
Inbox!

I've tested the patch on my Origen board and it works fine.  One small
comment in-line.

Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:

> From: Matthew Leach <matthew@mattleach.net>
>
> Enable the Origen's usb phy and ohci devices in the device tree.  Also
> add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
> the AX88760 hub is powered.
>
> Signed-off-by: Matthew Leach <matthew@mattleach.net>
> [k.kozlowski: Extend nodes by label notation instead of path]
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index 8bca699b7f20..4c59bdb0e6f3 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -77,12 +77,29 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +

I think we could loose this line break?

Thanks,
-- 
Matt

  reply	other threads:[~2016-05-11 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11  7:06 [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski
2016-05-11 18:18 ` Matthew Leach [this message]
2016-05-11 18:53   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y47gwj9k.fsf@mattleach.net \
    --to=matthew@mattleach.net \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox