From: Jacob Keller <jacob.e.keller@intel.com>
To: Chu Guangqing <chuguangqing@inspur.com>, <jes@trained-monkey.org>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.xn--org-o16s>,
<pabeni@redhat.com>
Cc: <linux-acenic@sunsite.dk>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map_page
Date: Wed, 22 Oct 2025 16:52:25 -0700 [thread overview]
Message-ID: <89daafd3-5234-4a61-8b4b-044e6e2d0c3e@intel.com> (raw)
In-Reply-To: <20251021020939.1121-1-chuguangqing@inspur.com>
[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]
On 10/20/2025 7:09 PM, Chu Guangqing wrote:
> After introduction of dma_map_phys(), there is no need to convert
> from physical address to struct page in order to map page. So let's
> use it directly.
>
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
> ---
Subject should include the tree tag to help automation when determining
where to apply the patch. Since this isn't a fix, this should target the
next tree with [PATCH net-next]. In the future try to remember to
include the tree in your tags for the subject.
The change itself looks reasonable. This converts the chain of
virt_to_page and offset_in_page of the driver followed by page_to_phys
in the core dma_map_page code into just virt_to_phys in the driver.
Makes sense.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2025-10-22 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 2:09 [PATCH] net: alteon: migrate to dma_map_phys instead of map_page Chu Guangqing
2025-10-22 23:52 ` Jacob Keller [this message]
2025-10-23 11:03 ` Paolo Abeni
2025-10-27 13:52 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89daafd3-5234-4a61-8b4b-044e6e2d0c3e@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=chuguangqing@inspur.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jes@trained-monkey.org \
--cc=kuba@kernel.xn--org-o16s \
--cc=linux-acenic@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox