From: Paolo Abeni <pabeni@redhat.com>
To: Chu Guangqing <chuguangqing@inspur.com>,
jes@trained-monkey.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com,
kuba@kernel.xn--org-o16s
Cc: linux-acenic@sunsite.dk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map_page
Date: Thu, 23 Oct 2025 13:03:30 +0200 [thread overview]
Message-ID: <1fb1a9dc-e4c0-40a0-9536-82653b5d0598@redhat.com> (raw)
In-Reply-To: <20251021020939.1121-1-chuguangqing@inspur.com>
On 10/21/25 4:09 AM, Chu Guangqing wrote:
> @@ -2362,9 +2359,8 @@ ace_map_tx_skb(struct ace_private *ap, struct sk_buff *skb,
> dma_addr_t mapping;
> struct tx_ring_info *info;
>
> - mapping = dma_map_page(&ap->pdev->dev, virt_to_page(skb->data),
> - offset_in_page(skb->data), skb->len,
> - DMA_TO_DEVICE);
> + mapping = dma_map_phys(&ap->pdev->dev, skb->data,
> + skb->len, DMA_TO_DEVICE, 0);
It looks like here a virt_to_phys() is missing around skb->data.
/P
next prev parent reply other threads:[~2025-10-23 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 2:09 [PATCH] net: alteon: migrate to dma_map_phys instead of map_page Chu Guangqing
2025-10-22 23:52 ` Jacob Keller
2025-10-23 11:03 ` Paolo Abeni [this message]
2025-10-27 13:52 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fb1a9dc-e4c0-40a0-9536-82653b5d0598@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=chuguangqing@inspur.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jes@trained-monkey.org \
--cc=kuba@kernel.xn--org-o16s \
--cc=linux-acenic@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox