public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Jürgen Groß" <jgross@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
	"Felix Fietkau" <nbd@nbd.name>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Ryder Lee" <ryder.lee@mediatek.com>,
	linux-pci@vger.kernel.org
Subject: Re: Config space access to Mediatek MT7922 doesn't work after device reset in Xen PV dom0 (regression, Linux 6.12)
Date: Wed, 29 Jan 2025 14:54:41 +0100	[thread overview]
Message-ID: <8acfd9b2-caae-4fe7-8d37-19e2d9be23a8@suse.com> (raw)
In-Reply-To: <20250129132843.GA451331@bhelgaas>

On 29.01.2025 14:28, Bjorn Helgaas wrote:
> On Wed, Jan 29, 2025 at 10:17:20AM +0100, Jan Beulich wrote:
>> On 29.01.2025 04:22, Marek Marczykowski-Górecki wrote:
>>> On Tue, Jan 28, 2025 at 09:03:15PM -0600, Bjorn Helgaas wrote:
>>>> The report claims the problem only happens with Xen.  I'm not a Xen
>>>> person, and I don't know how to find the relevant config accessors.
>>>> The snippets of kernel messages I see at [1] all mention pciback, so
>>>> that's my only clue of where to look.  Bottom line, I have no idea
>>>> what the config accessor path is, and maybe we could learn something
>>>> by looking at whatever it is.
>>>
>>> AFAIK there are no separate config accessors under Xen dom0, the default
>>> ones are used. xen-pcifront takes over PCI config space access (and few
>>> more) only in a domU (and only for PV), when PCI passthrough is used.
>>> Here, it didn't went that far...
>>>
>>> But then, Xen may intercept such access [2]. If I read it right, it
>>> should allow all access (is_hardware_domain(dom0)==true, and also the
>>> device is not on ro_map - otherwise reset wouldn't work at all).
>>
>> The other day you mentioned (on Matrix I think) that you observe mmcfg
>> not being used on that system. Am I misremembering? (Since the capability
>> where the control bit lives is an extended one, that capability would
>> neither be read nor modified when mmcfg is unavailable.)
> 
> If you're referring to the Configuration RRS Software Visibility
> Enable bit, that's in the PCIe Capability Root Control register, which
> is in the PCI-compatible config space (the first 256 bytes), not the
> extended config space.

Oh, I clearly didn't read Marek's earlier mail correctly. I'm sorry for that.

Jan

  reply	other threads:[~2025-01-29 13:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 12:05 Config space access to Mediatek MT7922 doesn't work after device reset in Xen PV dom0 (regression, Linux 6.12) Marek Marczykowski-Górecki
2025-01-29  1:15 ` Bjorn Helgaas
2025-01-29  2:10   ` Marek Marczykowski-Górecki
2025-01-29  3:03     ` Bjorn Helgaas
2025-01-29  3:22       ` Marek Marczykowski-Górecki
2025-01-29  3:40         ` Bjorn Helgaas
2025-01-29  3:47           ` Marek Marczykowski-Górecki
2025-01-29 13:32             ` Bjorn Helgaas
2025-01-29 13:52               ` Jan Beulich
2025-01-29 14:50                 ` Bjorn Helgaas
2025-01-29  9:17         ` Jan Beulich
2025-01-29 11:53           ` Marek Marczykowski-Górecki
2025-01-29 12:49             ` Jan Beulich
2025-01-29 13:28           ` Bjorn Helgaas
2025-01-29 13:54             ` Jan Beulich [this message]
2025-01-29 18:48     ` Bjorn Helgaas
2025-01-30  4:55       ` Marek Marczykowski-Górecki
2025-01-30  9:30         ` Jan Beulich
2025-01-30 21:31           ` Bjorn Helgaas
2025-01-31  7:13             ` Jan Beulich
2025-01-31  8:36               ` Marek Marczykowski-Górecki
2025-02-05 22:14             ` Marek Marczykowski-Górecki
2025-02-07 22:00               ` Bjorn Helgaas
2025-02-07 22:10                 ` Marek Marczykowski-Górecki
2025-02-07 22:23               ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8acfd9b2-caae-4fe7-8d37-19e2d9be23a8@suse.com \
    --to=jbeulich@suse.com \
    --cc=bhelgaas@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=helgaas@kernel.org \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=marmarek@invisiblethingslab.com \
    --cc=nbd@nbd.name \
    --cc=regressions@lists.linux.dev \
    --cc=roger.pau@citrix.com \
    --cc=ryder.lee@mediatek.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox