From: "Singh, Balbir" <sblbir@amazon.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "keescook@chromium.org" <keescook@chromium.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@intel.com" <dave.hansen@intel.com>
Subject: Re: [PATCH v3 1/5] arch/x86/kvm: Refactor l1d flush lifecycle management
Date: Fri, 17 Apr 2020 22:34:27 +0000 [thread overview]
Message-ID: <8c0cbcbd6270f333699bb1b9db113bbe99c98396.camel@amazon.com> (raw)
In-Reply-To: <871rommfs1.fsf@nanos.tec.linutronix.de>
On Fri, 2020-04-17 at 14:57 +0200, Thomas Gleixner wrote:
> CAUTION: This email originated from outside of the organization. Do not
> click links or open attachments unless you can confirm the sender and know
> the content is safe.
>
>
>
> Balbir Singh <sblbir@amazon.com> writes:
> > #include <asm-generic/cacheflush.h>
> > #include <asm/special_insns.h>
> >
> > +#define L1D_CACHE_ORDER 4
>
> Newline between constants and declarations please
>
> > void clflush_cache_range(void *addr, unsigned int size);
> > +void *alloc_l1d_flush_pages(void);
> > +void cleanup_l1d_flush_pages(void *l1d_flush_pages);
>
> Can we please have a consistent name space prefix?
>
> l1d_flush_*()
>
I used l1d_flush_pages as a noun and then a verb in front of it to denote
action alloc_l1d_flush_pages(), happy to change it over, don't feel to
strongly about it.
Balbir
next prev parent reply other threads:[~2020-04-17 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 9:02 [PATCH v3 0/5] Optionally flush L1D on context switch Balbir Singh
2020-04-08 9:02 ` [PATCH v3 1/5] arch/x86/kvm: Refactor l1d flush lifecycle management Balbir Singh
2020-04-17 12:57 ` Thomas Gleixner
2020-04-17 22:34 ` Singh, Balbir [this message]
2020-04-08 9:02 ` [PATCH v3 2/5] arch/x86: Refactor tlbflush and l1d flush Balbir Singh
2020-04-17 13:03 ` Thomas Gleixner
2020-04-17 22:58 ` Singh, Balbir
2020-04-08 9:02 ` [PATCH v3 3/5] arch/x86/mm: Refactor cond_ibpb() to support other use cases Balbir Singh
2020-04-17 13:07 ` Thomas Gleixner
2020-04-17 23:02 ` Singh, Balbir
2020-04-18 9:59 ` Thomas Gleixner
2020-04-21 3:46 ` Singh, Balbir
2020-04-21 9:02 ` Thomas Gleixner
2020-04-08 9:02 ` [PATCH v3 4/5] arch/x86: Optionally flush L1D on context switch Balbir Singh
2020-04-17 14:41 ` Thomas Gleixner
2020-04-18 1:30 ` Singh, Balbir
2020-04-18 10:17 ` Thomas Gleixner
2020-04-20 0:24 ` Singh, Balbir
2020-04-08 9:02 ` [PATCH v3 5/5] arch/x86: Add L1D flushing Documentation Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0cbcbd6270f333699bb1b9db113bbe99c98396.camel@amazon.com \
--to=sblbir@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@intel.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox