* Re: [PATCH v2 0/3] drm/panel: switch panel registration to devm_drm_panel_add() [not found] <20260423125922.57428-1-mhun512@gmail.com> @ 2026-05-07 7:13 ` Neil Armstrong [not found] ` <20260423125922.57428-4-mhun512@gmail.com> 1 sibling, 0 replies; 2+ messages in thread From: Neil Armstrong @ 2026-05-07 7:13 UTC (permalink / raw) To: Myeonghun Pak Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Sumit Semwal, Casey Connolly, dri-devel, linux-kernel On 4/23/26 14:59, Myeonghun Pak wrote: > This respins the previous attach-failure fixes as a single series. > > drm-misc-next now has devm_drm_panel_add() in commit e43a8e3ad8fa > ("drm/panel: add devm_drm_panel_add() helper"), so convert the three > affected panel drivers to the managed helper instead of open-coding > drm_panel_remove() in their failure and remove paths. > > Changes in v2: > - group the three related panel fixes into one series > - rebase onto drm-misc-next and use devm_drm_panel_add() > - drop manual drm_panel_remove() handling from probe/remove > > Myeonghun Pak (3): > drm/panel: ilitek-ili9881c: use devm_drm_panel_add() > drm/panel: jdi-fhd-r63452: use devm_drm_panel_add() > drm/panel: lg-sw43408: use devm_drm_panel_add() > > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 7 +++---- > drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 7 +++---- > drivers/gpu/drm/panel/panel-lg-sw43408.c | 10 +++++----- > 3 files changed, 11 insertions(+), 13 deletions(-) > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Thanks, Neil ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20260423125922.57428-4-mhun512@gmail.com>]
* Re: [PATCH v2 3/3] drm/panel: lg-sw43408: use devm_drm_panel_add() [not found] ` <20260423125922.57428-4-mhun512@gmail.com> @ 2026-05-07 9:03 ` Dmitry Baryshkov 0 siblings, 0 replies; 2+ messages in thread From: Dmitry Baryshkov @ 2026-05-07 9:03 UTC (permalink / raw) To: Myeonghun Pak Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Sumit Semwal, Casey Connolly, dri-devel, linux-kernel On Thu, Apr 23, 2026 at 09:59:22PM +0900, Myeonghun Pak wrote: > Replace drm_panel_add()/drm_panel_remove() with devm_drm_panel_add() > now that drm-misc-next provides it. This keeps panel deregistration tied > to the device lifetime and removes the manual cleanup from the remove > callback. > > Signed-off-by: Myeonghun Pak <mhun512@gmail.com> > --- > drivers/gpu/drm/panel/panel-lg-sw43408.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-lg-sw43408.c b/drivers/gpu/drm/panel/panel-lg-sw43408.c > index 293826c500..8969f57b89 100644 > --- a/drivers/gpu/drm/panel/panel-lg-sw43408.c > +++ b/drivers/gpu/drm/panel/panel-lg-sw43408.c > @@ -254,8 +254,11 @@ static int sw43408_add(struct sw43408_panel *ctx) > > ctx->base.prepare_prev_first = true; > > - drm_panel_add(&ctx->base); > - return ret; > + ret = devm_drm_panel_add(dev, &ctx->base); > + if (ret < 0) > + return dev_err_probe(dev, ret, "Failed to add panel\n"); > + > + return 0; > } > > static int sw43408_probe(struct mipi_dsi_device *dsi) > @@ -299,14 +302,11 @@ static int sw43408_probe(struct mipi_dsi_device *dsi) > > static void sw43408_remove(struct mipi_dsi_device *dsi) > { > - struct sw43408_panel *ctx = mipi_dsi_get_drvdata(dsi); > int ret; > > ret = mipi_dsi_detach(dsi); This begs to use devm_mipi_dsi_attach() in the probe function. The whole remove callback can be removed then. > if (ret < 0) > dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); > - > - drm_panel_remove(&ctx->base); > } > > static struct mipi_dsi_driver sw43408_driver = { > -- > 2.47.1 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-07 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260423125922.57428-1-mhun512@gmail.com>
2026-05-07 7:13 ` [PATCH v2 0/3] drm/panel: switch panel registration to devm_drm_panel_add() Neil Armstrong
[not found] ` <20260423125922.57428-4-mhun512@gmail.com>
2026-05-07 9:03 ` [PATCH v2 3/3] drm/panel: lg-sw43408: use devm_drm_panel_add() Dmitry Baryshkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox