* [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled
@ 2025-04-29 22:23 Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alistair Francis @ 2025-04-29 22:23 UTC (permalink / raw)
To: hch, sagi, kch, linux-nvme
Cc: linux-kernel, hare, alistair23, Alistair Francis
Ensure that TLS support is enabled in the kernel when
NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be
used out of the box.
Fixes: 675b453e0241 ("nvmet-tcp: enable TLS handshake upcall")
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/target/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
index fb7446d6d682..4c253b433bf7 100644
--- a/drivers/nvme/target/Kconfig
+++ b/drivers/nvme/target/Kconfig
@@ -98,6 +98,7 @@ config NVME_TARGET_TCP_TLS
bool "NVMe over Fabrics TCP target TLS encryption support"
depends on NVME_TARGET_TCP
select NET_HANDSHAKE
+ select TLS
help
Enables TLS encryption for the NVMe TCP target using the netlink handshake API.
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled
2025-04-29 22:23 [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled Alistair Francis
@ 2025-04-30 0:44 ` Chaitanya Kulkarni
2025-04-30 6:11 ` Hannes Reinecke
2025-04-30 13:11 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-04-30 0:44 UTC (permalink / raw)
To: Alistair Francis, hch@lst.de, sagi@grimberg.me,
Chaitanya Kulkarni, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, hare@suse.de, Alistair Francis
On 4/29/25 15:23, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: 675b453e0241 ("nvmet-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis<alistair.francis@wdc.com>
> Reviewed-by: Hannes Reinecke<hare@suse.de>
> Reviewed-by: Chaitanya Kulkarni<kch@nvidia.com>
I believe "nvme-tcp" subsystem is used on the host side,
maybe subject line needs to be replaced with following ?
nvmet-tcp: select tls config when tcp tls is enabled
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled
2025-04-29 22:23 [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
@ 2025-04-30 6:11 ` Hannes Reinecke
2025-04-30 13:11 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2025-04-30 6:11 UTC (permalink / raw)
To: Alistair Francis, hch, sagi, kch, linux-nvme
Cc: linux-kernel, Alistair Francis
On 4/30/25 00:23, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: 675b453e0241 ("nvmet-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/target/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
> index fb7446d6d682..4c253b433bf7 100644
> --- a/drivers/nvme/target/Kconfig
> +++ b/drivers/nvme/target/Kconfig
> @@ -98,6 +98,7 @@ config NVME_TARGET_TCP_TLS
> bool "NVMe over Fabrics TCP target TLS encryption support"
> depends on NVME_TARGET_TCP
> select NET_HANDSHAKE
> + select TLS
> help
> Enables TLS encryption for the NVMe TCP target using the netlink handshake API.
>
Can you fold both patches together?
If not, this patch need to be titled 'nvmet-tcp: select tls config ...'
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled
2025-04-29 22:23 [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
2025-04-30 6:11 ` Hannes Reinecke
@ 2025-04-30 13:11 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-04-30 13:11 UTC (permalink / raw)
To: Alistair Francis
Cc: hch, sagi, kch, linux-nvme, linux-kernel, hare, Alistair Francis
Thanks,
I've appllied both tls select patches with a bit of commit log tweaking
to the nvme-6.15 branch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-30 13:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29 22:23 [PATCH v2] nvme-tcp: select tls config when tcp tls is enabled Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
2025-04-30 6:11 ` Hannes Reinecke
2025-04-30 13:11 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox