Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/11/2025 00:41, Dmitry Baryshkov wrote:
> On Mon, Nov 24, 2025 at 04:09:56PM +0100, Krzysztof Kozlowski wrote:
>> On 24/11/2025 15:34, Dmitry Baryshkov wrote:
>>> On Sat, Nov 22, 2025 at 12:15:40PM +0100, Krzysztof Kozlowski wrote:
>>>> On 22/11/2025 12:00, Stephan Gerhold wrote:
>>>>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>>>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>>>>> [...]
>>>>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>>>>> Snapdragon X Elite SoC (X1E78100).
>>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>> Because the SoC is now outdated and some functions still do not work as
>>>>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>>>>>> will not be offered for sale. We would still like to submit our device
>>>>>>> tree to the mainline kernel and thus contribute to Linux support for a
>>>>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>>>>>> Germany, this device was sold in many large stores. (An official press
>>>>>>> statement will follow on our website.)
>>>>>>
>>>>>> For me this is unmergeable, because we do not take stuff which no one
>>>>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>>>>>> this was known to be cancelled.
>>>>>>
>>>>>
>>>>> I don't think we have any requirement to have a large user base in order
>>>>> to merge changes. There is already support for plenty of cancelled
>>>>> products with only a few (if any) remaining users in mainline, e.g.
>>>>>
>>>>>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>>>>>    handful of users before cancelled
>>>>>  - All ChromeOS SC7280 devices (including DTB variants for several
>>>>>    revisions of pre-production samples), never shipped to anyone
>>>>>
>>>>
>>>> I discuss here the timing primarily and I don't know the timing about them.
>>>>
>>>>> There are also plenty of internal reference devices that only a handful
>>>>> of people have access to (MTP, HDK, CRD etc). What makes these any
>>>>
>>>> They are still "maintained" and "offered", even if only for handful
>>>> (like 3000 EACH variant) people. That's the amount of board of each
>>>> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
>>>> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
>>>
>>> Where does 3000 come from? The Bible says 10 people were enough to
>>> maintain Sodom and Gomorrah. For Herobrine we know that there are very
>>> few people still using those devices (maybe less than 10), but we still
>>> keep it. Cheeza was dropped after it was known that the count is exactly
>>> zero.
>>>
>>>>
>>>>> different? Ettore has been actively testing and contributing to the port
>>>>> for the TUXEDO laptop, so if he wants to continue that, I don't think
>>>>> anything speaks against merging this device tree.
>>>>
>>>> I won't be maintaining it, so not my effort in that, but since you speak
>>>> about that - maintenance is an effort, thus I decide not to spend it on
>>>> cancelled products.
>>>>
>>>>>
>>>>> In any case, I don't think the time reviewing these changes is wasted:
>>>>
>>>> I am happy that you do not find my time wasted, but I disagree on that
>>>> because knowing this is cancelled, I would probably not care and review
>>>> products which are not cancelled at this time.
>>>
>>> There still people owning and being happy with those laptops. It's
>>> Bjorn's and Konrad's time being spent on maintaining those. What's the
>>> issue?
>>
>>
>> I think I described my issue very precise. Please read my first reply in
>> this thread. Joining discussion at the end of it, not reading it and
>> then asking "what is the issue" is not really encouraging me to discuss
>> whether this is a problem or not.
> 
> I had read it before replying.

So I said that issue is that I wasted time on reviewing something I
would not review, if this was clearly marked correctly, because I would
consider it waste of time and you asked "what is the issue?"

What sort of question is that? I just wrote what is the issue... And you
ask what issue?


Best regards,
Krzysztof