Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/11/2025 15:26, Georg Gottleuber wrote:
> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> Snapdragon X Elite SoC (X1E78100).
> 
> Changes in v3:
> - add DisplayPort audio to dts
> - add el2.dtb to Makefile
> - change dts firmware paths
> - fix dt-binding (x1e78100 instead of x1e80100)
> - improve commit message for elite14gen1 dt-bindings
> - remove smb2360_1 from dts (only one USB-C port is present)
> - remove "VA MIC BIAS1" from dts
> - remove regulator-always-on from vreg_edp_3p3 (display) in dts
> - rename vendor prefix of ASL Xiamen Technology to asl-tek
> - sort dts
> 
> Changes in v2:
> - Rebase to v6.18-rc4/master
> - Add support for accelerated video decoding
> - Add support for audio (speakers, microphones, headset)
> - Add support for Bluetooth
> - Add support for camera
> - Add support for fingerprint reader
> - Add support for HDMI-A port
> - Add support for QSEECOM
> - Add support for USB Type-A
> - Add support for USB-C DP altmode
> - Add ASL Xiamen Technology Co. Ltd. vendor prefix
> - Add TUXEDO vendor prefix
> - Add cover letter
> - Removal of pointless comments
> - Coding style fixes
> - Spell check
> 
> The device tree uses the dtschema from Linaro DisplayPort PHY patch [1].
> ALSA UCM and Audioreach topology patches are available at [2] and [3].
> The fingerprint reader requires USB IDs to be patched into libfprint.
> WiFi requires a firmware patch [4].
> 
> Announcement and request for comments:

This should be FIRST part of cover letter, so we won't waste time on
reviewing it, instead of burying it deep. Additionally, you should have
named the series RFC.

> Because the SoC is now outdated and some functions still do not work as
> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
> will not be offered for sale. We would still like to submit our device
> tree to the mainline kernel and thus contribute to Linux support for a
> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
> Germany, this device was sold in many large stores. (An official press
> statement will follow on our website.)

For me this is unmergeable, because we do not take stuff which no one
uses (no one can even use), and I am sad I put effort in reviewing AFTER
this was known to be cancelled.


Best regards,
Krzysztof