public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "David Gow" <davidgow@google.com>,
	shuah@kernel.org,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"Rae Moar" <raemoar63@gmail.com>
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] kunit: tool: test: Rename test_data_path() to _test_data_path()
Date: Wed, 7 Jan 2026 10:28:17 -0700	[thread overview]
Message-ID: <8f7a03a1-7c5a-4a98-978d-e5ae9c926036@linuxfoundation.org> (raw)
In-Reply-To: <20260107015936.2316047-1-davidgow@google.com>

On 1/6/26 18:59, David Gow wrote:
> From: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> Running the KUnit testsuite through pytest fails, as the function
> test_data_path() is recognized as a test function. Its execution fails
> as pytest tries to resolve the 'path' argument as a fixture which does
> not exist.
> 
> Rename the function, so the helper function is not incorrectly
> recognized as a test function.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> Reviewed-by: David Gow <davidgow@google.com>
> Signed-off-by: David Gow <davidgow@google.com>
> ---
> 
> Changes since v1:
> https://lore.kernel.org/linux-kselftest/20251230-kunit-pytest-v1-1-e2dae0dae200@linutronix.de/
>   - Rebase on top of "kunit: tool: Add test for nested test result
>     reporting"
>     https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=0c5b86c67fb6898d02c8f92de884186297fd302f
> 

Thank you.

Applied to linux kselftest kunit repo for Linux 6.20-rc1

thanks,
-- Shuah

  parent reply	other threads:[~2026-01-07 17:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  1:59 [PATCH v2 1/2] kunit: tool: test: Rename test_data_path() to _test_data_path() David Gow
2026-01-07  1:59 ` [PATCH v2 2/2] kunit: tool: test: Don't rely on implicit working directory change David Gow
2026-01-07 17:28   ` Shuah Khan
2026-01-07 17:28 ` Shuah Khan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-01-07 12:51 [PATCH v2 0/2] kunit: tool: test: Allow running with pytest Thomas Weißschuh
2026-01-07 12:51 ` [PATCH v2 1/2] kunit: tool: test: Rename test_data_path() to _test_data_path() Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f7a03a1-7c5a-4a98-978d-e5ae9c926036@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=raemoar63@gmail.com \
    --cc=shuah@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox