The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Cc: chen.zhong@mediatek.com, chenglin.xu@mediatek.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 7/7] soc: mediatek: pwrap: fixup warnings from coding style
Date: Mon, 16 Oct 2017 17:02:02 +0200	[thread overview]
Message-ID: <8fa7858f-7a73-1275-f345-24efa48e957c@gmail.com> (raw)
In-Reply-To: <e9ae9b01628924bb0715227064c307ffe613ae50.1508135937.git.sean.wang@mediatek.com>



On 10/16/2017 09:07 AM, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> fixup those warnings such as lines over 80 words and parenthesis
> alignment which would be complained by checkpatch.pl.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---

I already took this patch, please drop from series.

Thanks


>   drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++-------
>   1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 9ac304a..51b8894 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1101,7 +1101,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>   	/* wait for cipher data ready@PMIC */
>   	ret = pwrap_wait_for_state(wrp, pwrap_is_pmic_cipher_ready);
>   	if (ret) {
> -		dev_err(wrp->dev, "timeout waiting for cipher data ready@PMIC\n");
> +		dev_err(wrp->dev,
> +			"timeout waiting for cipher data ready@PMIC\n");
>   		return ret;
>   	}
>   
> @@ -1496,23 +1497,27 @@ static int pwrap_probe(struct platform_device *pdev)
>   		if (IS_ERR(wrp->bridge_base))
>   			return PTR_ERR(wrp->bridge_base);
>   
> -		wrp->rstc_bridge = devm_reset_control_get(wrp->dev, "pwrap-bridge");
> +		wrp->rstc_bridge = devm_reset_control_get(wrp->dev,
> +							  "pwrap-bridge");
>   		if (IS_ERR(wrp->rstc_bridge)) {
>   			ret = PTR_ERR(wrp->rstc_bridge);
> -			dev_dbg(wrp->dev, "cannot get pwrap-bridge reset: %d\n", ret);
> +			dev_dbg(wrp->dev,
> +				"cannot get pwrap-bridge reset: %d\n", ret);
>   			return ret;
>   		}
>   	}
>   
>   	wrp->clk_spi = devm_clk_get(wrp->dev, "spi");
>   	if (IS_ERR(wrp->clk_spi)) {
> -		dev_dbg(wrp->dev, "failed to get clock: %ld\n", PTR_ERR(wrp->clk_spi));
> +		dev_dbg(wrp->dev, "failed to get clock: %ld\n",
> +			PTR_ERR(wrp->clk_spi));
>   		return PTR_ERR(wrp->clk_spi);
>   	}
>   
>   	wrp->clk_wrap = devm_clk_get(wrp->dev, "wrap");
>   	if (IS_ERR(wrp->clk_wrap)) {
> -		dev_dbg(wrp->dev, "failed to get clock: %ld\n", PTR_ERR(wrp->clk_wrap));
> +		dev_dbg(wrp->dev, "failed to get clock: %ld\n",
> +			PTR_ERR(wrp->clk_wrap));
>   		return PTR_ERR(wrp->clk_wrap);
>   	}
>   
> @@ -1557,8 +1562,9 @@ static int pwrap_probe(struct platform_device *pdev)
>   	pwrap_writel(wrp, wrp->master->int_en_all, PWRAP_INT_EN);
>   
>   	irq = platform_get_irq(pdev, 0);
> -	ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt, IRQF_TRIGGER_HIGH,
> -			"mt-pmic-pwrap", wrp);
> +	ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt,
> +			       IRQF_TRIGGER_HIGH,
> +			       "mt-pmic-pwrap", wrp);
>   	if (ret)
>   		goto err_out2;
>   
> 

      reply	other threads:[~2017-10-16 15:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  7:07 [PATCH v5 0/7] Add PMIC support to MediaTek MT7622 SoC sean.wang
2017-10-16  7:07 ` [PATCH v5 1/7] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc sean.wang
2017-10-16  7:07 ` [PATCH v5 2/7] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode sean.wang
2017-10-16  7:07 ` [PATCH v5 3/7] soc: mediatek: pwrap: add pwrap_write32 for writing " sean.wang
2017-10-16  7:07 ` [PATCH v5 4/7] soc: mediatek: pwrap: refactor pwrap_init for the various PMIC types sean.wang
2017-10-16  7:07 ` [PATCH v5 5/7] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap sean.wang
2017-10-16  7:07 ` [PATCH v5 6/7] soc: mediatek: pwrap: add support for MT7622 SoC sean.wang
2017-10-16 15:00   ` Matthias Brugger
2017-10-17  9:49     ` Sean Wang
2017-10-17 10:34       ` Matthias Brugger
2017-10-16  7:07 ` [PATCH v5 7/7] soc: mediatek: pwrap: fixup warnings from coding style sean.wang
2017-10-16 15:02   ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fa7858f-7a73-1275-f345-24efa48e957c@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=chen.zhong@mediatek.com \
    --cc=chenglin.xu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox