From: Hans de Goede <johannes.goede@oss.qualcomm.com>
To: Marco Scardovi <scardracs@disroot.org>,
bnatikar@amd.com, Armin Wolf <W_Armin@gmx.de>
Cc: andriy.shevchenko@linux.intel.com, brgl@kernel.org,
linusw@kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
mario.limonciello@amd.com, westeri@kernel.org
Subject: Re: [PATCH v2 0/1] gpiolib: acpi: Add quirk for ASUS ROG Strix G16 G614 series
Date: Sun, 21 Jun 2026 13:00:22 +0200 [thread overview]
Message-ID: <9237988a-2f5a-4c4e-8586-12899957bfea@oss.qualcomm.com> (raw)
In-Reply-To: <20260617185318.11237-1-scardracs@disroot.org>
Hi Marco,
On 17-Jun-26 20:50, Marco Scardovi wrote:
> Hi Basavaraj,
>
> Thank you for your review: this is the v2 with the rewording as requested.
>
> Changes in v2:
> - Reworded the commit message and the code comment to explain the actual
> boot-time replay mechanism as suggested by Basavaraj.
> - Explicitly noted that the touchpad itself is driven by i2c-hid and functions
> normally, and that the ACPI event handler is preserved for post-boot events.
> - Rebased against linux-next-20260616
>
> Marco Scardovi (1):
> gpiolib: acpi: Add quirk for ASUS ROG Strix G16 G614 series
Have you tried adding this patch to your kernel instead of adding a quirk? :
https://lore.kernel.org/linux-gpio/20260429025247.1372984-1-mario.limonciello@amd.com/
This modifies the code which does an initial sync of edge-run ACPI GPIO
interrupt event handlers to match Windows and to skip it in certain
circumstances.
If that does not help, we should wait for Armin to get a chance to check
your DSDT to see if the magic _DSM which inverts the polarity check for
the initial sync run is there.
By matching what Windows this we can hopefully fix this for a whole bunch
of devices rather then having to rely on per model quirks.
Regards,
Hans
next prev parent reply other threads:[~2026-06-21 11:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 9:08 [PATCH] gpiolib: acpi: Add quirk for ASUS ROG Strix G614 series Marco Scardovi
2026-06-16 9:31 ` Andy Shevchenko
2026-06-16 9:43 ` Marco Scardovi
2026-06-16 9:58 ` Andy Shevchenko
2026-06-16 10:24 ` Mika Westerberg
2026-06-16 10:58 ` Marco Scardovi
2026-06-16 11:04 ` Andy Shevchenko
2026-06-17 8:51 ` Marco Scardovi
2026-06-17 8:52 ` Marco Scardovi
2026-06-17 18:34 ` Basavaraj Natikar
2026-06-17 18:50 ` [PATCH v2 0/1] gpiolib: acpi: Add quirk for ASUS ROG Strix G16 " Marco Scardovi
2026-06-17 18:50 ` [PATCH v2 1/1] " Marco Scardovi
2026-06-17 21:23 ` [PATCH v2 0/1] " Armin Wolf
2026-06-17 23:14 ` Marco Scardovi
2026-06-18 13:16 ` Basavaraj Natikar
2026-06-18 14:35 ` Andy Shevchenko
2026-06-18 16:59 ` Marco Scardovi
2026-06-18 18:01 ` Andy Shevchenko
2026-06-18 18:07 ` Marco Scardovi
2026-06-19 10:17 ` Basavaraj Natikar
2026-06-19 10:28 ` Marco Scardovi
2026-06-20 6:52 ` Andy Shevchenko
2026-06-20 7:20 ` Marco Scardovi
2026-06-21 7:58 ` Mario Limonciello
2026-06-21 11:00 ` Hans de Goede [this message]
2026-06-21 12:38 ` Marco Scardovi
2026-06-24 14:42 ` Armin Wolf
2026-06-24 17:49 ` Marco Scardovi
2026-06-25 6:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9237988a-2f5a-4c4e-8586-12899957bfea@oss.qualcomm.com \
--to=johannes.goede@oss.qualcomm.com \
--cc=W_Armin@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bnatikar@amd.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=scardracs@disroot.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox