Re: [PATCH v2 0/1] gpiolib: acpi: Add quirk for ASUS ROG Strix G16 G614 series

[Armin Wolf <W_Armin@gmx.de>]

Am 21.06.26 um 13:00 schrieb Hans de Goede:

> Hi Marco,
>
> On 17-Jun-26 20:50, Marco Scardovi wrote:
>> Hi Basavaraj,
>>
>> Thank you for your review: this is the v2 with the rewording as requested.
>>
>> Changes in v2:
>> - Reworded the commit message and the code comment to explain the actual
>>    boot-time replay mechanism as suggested by Basavaraj.
>> - Explicitly noted that the touchpad itself is driven by i2c-hid and functions
>>    normally, and that the ACPI event handler is preserved for post-boot events.
>> - Rebased against linux-next-20260616
>>
>> Marco Scardovi (1):
>>    gpiolib: acpi: Add quirk for ASUS ROG Strix G16 G614 series
> Have you tried adding this patch to your kernel instead of adding a quirk? :
>
> https://lore.kernel.org/linux-gpio/20260429025247.1372984-1-mario.limonciello@amd.com/
>
> This modifies the code which does an initial sync of edge-run ACPI GPIO
> interrupt event handlers to match Windows and to skip it in certain
> circumstances.
>
> If that does not help, we should wait for Armin to get a chance to check
> your DSDT to see if the magic _DSM which inverts the polarity check for
> the initial sync run is there.

I checked the ACPI tables, and the _DSM is missing. However i think that the
affected GPIO is actually declared as being edge-triggered, so the aforementioned
patch from mario should fix the problem without requiring another quirk entry.

Thanks,
Armin Wolf

>
> By matching what Windows this we can hopefully fix this for a whole bunch
> of devices rather then having to rely on per model quirks.
>
> Regards,
>
> Hans
>
>