* Re: [PATCH v4] net: ethernet: renesas: rswitch: fix device_node refcount leak in rswitch_get_port_node()
[not found] <6a882352.ee10049a.267d65.7a31@mx.google.com>
@ 2026-08-24 8:15 ` Markus Elfring
2026-08-24 13:12 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2026-08-24 8:15 UTC (permalink / raw)
To: manushprajwal555, netdev, linux-renesas-soc, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Michael Dege,
Paolo Abeni, Yoshihiro Shimoda
Cc: LKML
…
> Rework the function around for_each_available_child_of_node_scoped()
> instead of adding a manual of_node_put(), so the iterator's reference
> is dropped automatically on every exit path. Since port is the
> function's return value, take an explicit reference with of_node_get()
> on the match before breaking out of the loop.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/ethernet/renesas/rswitch_main.c?h=v7.2
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-netdev.rst?id=v7.2#n3
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] net: ethernet: renesas: rswitch: fix device_node refcount leak in rswitch_get_port_node()
2026-08-24 8:15 ` [PATCH v4] net: ethernet: renesas: rswitch: fix device_node refcount leak in rswitch_get_port_node() Markus Elfring
@ 2026-08-24 13:12 ` Andrew Lunn
2026-08-24 13:30 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2026-08-24 13:12 UTC (permalink / raw)
To: Markus Elfring
Cc: manushprajwal555, netdev, linux-renesas-soc, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Michael Dege,
Paolo Abeni, Yoshihiro Shimoda, LKML
On Mon, Aug 24, 2026 at 10:15:15AM +0200, Markus Elfring wrote:
> …
> > Rework the function around for_each_available_child_of_node_scoped()
> > instead of adding a manual of_node_put(), so the iterator's reference
> > is dropped automatically on every exit path. Since port is the
> > function's return value, take an explicit reference with of_node_get()
> > on the match before breaking out of the loop.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
>
> See also:
> * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
> * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
Hi Markus
The stable rules include the statement, the bug being fixed must
bother somebody. Do you know of somebody bothered by the reference
leak?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] net: ethernet: renesas: rswitch: fix device_node refcount leak in rswitch_get_port_node()
2026-08-24 13:12 ` Andrew Lunn
@ 2026-08-24 13:30 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2026-08-24 13:30 UTC (permalink / raw)
To: Andrew Lunn, Manush Prajwal, netdev, linux-renesas-soc
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Michael Dege, Paolo Abeni, Yoshihiro Shimoda, LKML
>> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
>>
>> See also:
>> * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
>> * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
…
> The stable rules include the statement, the bug being fixed must
> bother somebody.
There are failure possibilities involved.
> Do you know of somebody bothered by the reference leak?
My personal knowledge is probably too limited for this issue so far.
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-24 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <6a882352.ee10049a.267d65.7a31@mx.google.com>
2026-08-24 8:15 ` [PATCH v4] net: ethernet: renesas: rswitch: fix device_node refcount leak in rswitch_get_port_node() Markus Elfring
2026-08-24 13:12 ` Andrew Lunn
2026-08-24 13:30 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).