From: gaoxu <gaoxu2@honor.com>
To: "Kamalesh Babulal" <kamalesh.babulal@oracle.com>,
"Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>
Cc: "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"surenb@google.com" <surenb@google.com>,
yipengxiang <yipengxiang@honor.com>
Subject: 回复: [PATCH] cgroup: Fix compilation issue due to cgroup_mutex not being exported
Date: Fri, 18 Apr 2025 02:03:43 +0000 [thread overview]
Message-ID: <93828629f46942b487ec2f6fd6dd373f@honor.com> (raw)
In-Reply-To: <d7cf14f0-213f-4e15-abe8-cc09a293c4fc@oracle.com>
>
> On 4/17/25 1:00 PM, gaoxu wrote:
> [...]
>
> > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index
> > 447ac857e..9e60ff629 100644
> > --- a/kernel/cgroup/cgroup.c
> > +++ b/kernel/cgroup/cgroup.c
> > @@ -90,7 +90,7 @@
> > DEFINE_MUTEX(cgroup_mutex);
> > DEFINE_SPINLOCK(css_set_lock);
> >
> > -#ifdef CONFIG_PROVE_RCU
> > +#if (defined CONFIG_PROVE_RCU || defined CONFIG_LOCKDEP)
> > EXPORT_SYMBOL_GPL(cgroup_mutex);
> > EXPORT_SYMBOL_GPL(css_set_lock);
> > #endif
>
>
> It can be triggered when CONFIG_LOCK_STAT=y is enabled, which selects
> CONFIG_LOCKDEP=y and sets CONFIG_PROVE_RCU=n. The patch looks good to
> me.
>
> You may also want to update the description above
> DEFINE_MUTEX(cgroup_mutex); to reflect the modifications introduced by this
> patch.
Received, thanks!
>
> --
> Cheers,
> Kamalesh
next prev parent reply other threads:[~2025-04-18 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 7:30 [PATCH] cgroup: Fix compilation issue due to cgroup_mutex not being exported gaoxu
2025-04-17 9:18 ` Michal Koutný
2025-04-17 16:16 ` Kamalesh Babulal
2025-04-18 2:03 ` gaoxu [this message]
2025-04-17 16:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93828629f46942b487ec2f6fd6dd373f@honor.com \
--to=gaoxu2@honor.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamalesh.babulal@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=yipengxiang@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox