From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
To: gaoxu <gaoxu2@honor.com>, "Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>
Cc: "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"surenb@google.com" <surenb@google.com>,
yipengxiang <yipengxiang@honor.com>
Subject: Re: [PATCH] cgroup: Fix compilation issue due to cgroup_mutex not being exported
Date: Thu, 17 Apr 2025 21:46:00 +0530 [thread overview]
Message-ID: <d7cf14f0-213f-4e15-abe8-cc09a293c4fc@oracle.com> (raw)
In-Reply-To: <24763f5c8a13421fa6dc3672a57a7836@honor.com>
On 4/17/25 1:00 PM, gaoxu wrote:
[...]
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 447ac857e..9e60ff629 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -90,7 +90,7 @@
> DEFINE_MUTEX(cgroup_mutex);
> DEFINE_SPINLOCK(css_set_lock);
>
> -#ifdef CONFIG_PROVE_RCU
> +#if (defined CONFIG_PROVE_RCU || defined CONFIG_LOCKDEP)
> EXPORT_SYMBOL_GPL(cgroup_mutex);
> EXPORT_SYMBOL_GPL(css_set_lock);
> #endif
It can be triggered when CONFIG_LOCK_STAT=y is enabled, which
selects CONFIG_LOCKDEP=y and sets CONFIG_PROVE_RCU=n. The patch
looks good to me.
You may also want to update the description above DEFINE_MUTEX(cgroup_mutex);
to reflect the modifications introduced by this patch.
--
Cheers,
Kamalesh
next prev parent reply other threads:[~2025-04-17 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 7:30 [PATCH] cgroup: Fix compilation issue due to cgroup_mutex not being exported gaoxu
2025-04-17 9:18 ` Michal Koutný
2025-04-17 16:16 ` Kamalesh Babulal [this message]
2025-04-18 2:03 ` 回复: " gaoxu
2025-04-17 16:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7cf14f0-213f-4e15-abe8-cc09a293c4fc@oracle.com \
--to=kamalesh.babulal@oracle.com \
--cc=cgroups@vger.kernel.org \
--cc=gaoxu2@honor.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=yipengxiang@honor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox