From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Prakash Sangappa <prakash.sangappa@oracle.com>,
linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, tglx@linutronix.de,
bigeasy@linutronix.de, vineethr@linux.ibm.com
Subject: Re: [PATCH V6 0/7] Scheduler time slice extension
Date: Tue, 1 Jul 2025 10:00:56 +0530 [thread overview]
Message-ID: <94190673-8978-4bcb-9755-bed718fa99ee@amd.com> (raw)
In-Reply-To: <20250701003749.50525-1-prakash.sangappa@oracle.com>
Hello Prakash,
On 7/1/2025 6:07 AM, Prakash Sangappa wrote:
> Prakash Sangappa (7):
> Sched: Scheduler time slice extension
> Sched: Indicate if thread got rescheduled
> Sched: Tunable to specify duration of time slice extension
> Sched: Add scheduler stat for cpu time slice extension
> Sched: Add tracepoint for sched time slice extension
> Add API to query supported rseq cs flags
> Introduce a config option for scheduler time slice extension feature
nit.
IMO, the ordering of these patches can be improved. Introduction of
CONFIG_SCHED_PREEMPT_DELAY can come first followed by incrementally
adding the scheduler bits, followed by "rseq: Add API to query supported
rseq cs flags" and then finally introduce the bits that introduces
"RSEQ_CS_FLAG_DELAY_RESCHED" and allows the user to set.
This way all the CONFIG_SCHED_PREEMPT_DELAY can live in one place and
make it easier to review the entire series.
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2025-07-01 4:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 0:37 [PATCH V6 0/7] Scheduler time slice extension Prakash Sangappa
2025-07-01 0:37 ` [PATCH V6 1/7] Sched: " Prakash Sangappa
2025-07-01 8:42 ` Thomas Gleixner
2025-07-01 10:56 ` Peter Zijlstra
2025-07-01 11:28 ` K Prateek Nayak
2025-07-01 11:40 ` Peter Zijlstra
2025-07-01 12:36 ` Thomas Gleixner
2025-07-01 14:49 ` Steven Rostedt
2025-07-03 5:38 ` Prakash Sangappa
2025-07-03 8:32 ` Thomas Gleixner
2025-07-01 18:40 ` Prakash Sangappa
2025-07-01 0:37 ` [PATCH V6 2/7] Sched: Indicate if thread got rescheduled Prakash Sangappa
2025-07-01 0:37 ` [PATCH V6 3/7] Sched: Tunable to specify duration of time slice extension Prakash Sangappa
2025-07-01 3:59 ` K Prateek Nayak
2025-07-01 0:37 ` [PATCH V6 4/7] Sched: Add scheduler stat for cpu " Prakash Sangappa
2025-07-01 0:37 ` [PATCH V6 5/7] Sched: Add tracepoint for sched " Prakash Sangappa
2025-07-01 0:37 ` [PATCH V6 6/7] Add API to query supported rseq cs flags Prakash Sangappa
2025-07-01 0:37 ` [PATCH V6 7/7] Introduce a config option for scheduler time slice extension feature Prakash Sangappa
2025-07-01 3:12 ` K Prateek Nayak
2025-07-01 17:47 ` Prakash Sangappa
2025-07-01 8:46 ` Thomas Gleixner
2025-07-01 19:04 ` Prakash Sangappa
2025-07-01 4:30 ` K Prateek Nayak [this message]
2025-07-01 19:04 ` [PATCH V6 0/7] Scheduler time slice extension Prakash Sangappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94190673-8978-4bcb-9755-bed718fa99ee@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=prakash.sangappa@oracle.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vineethr@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox