Re: [PATCH 3/4] dt-bindings: media: mediatek-jpeg-encoder: add MT8189 compatible string

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/12/2025 02:52, Jianhua Lin wrote:
> Compared to the previous generation IC, the MT8189 uses 34-bit
> iova address-space. Therefore, add "mediatek,mt8189-jpgenc"
> compatible to the binding document.
> 
> Signed-off-by: Jianhua Lin <jianhua.lin@mediatek.com>
> ---
>  .../bindings/media/mediatek-jpeg-encoder.yaml | 27 ++++++++++++++-----
>  1 file changed, 20 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> index 5b15f8977f67..3044c7fc5c18 100644
> --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> @@ -14,13 +14,22 @@ description: |-
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - mediatek,mt2701-jpgenc
> -          - mediatek,mt8183-jpgenc
> -          - mediatek,mt8186-jpgenc
> -          - mediatek,mt8188-jpgenc
> -      - const: mediatek,mtk-jpgenc
> +    oneOf:
> +      - items:
> +          - enum:
> +              - mediatek,mtk-jpgenc

NAK, makes absolutely no sense. It is contradictory to the main DT
rules, expressed in writing bindings or on numerous presentations.

You cannot have generic front compatible because it expressed nothing.
Plus this is really, really not properly explained in the commit msg.

Did you receive proper internal review, before posting? Considering
absolutely poor quality patches from Mediatek, I find it as a
requirement now.

Best regards,
Krzysztof