From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jianhua Lin <jianhua.lin@mediatek.com>,
mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
sirius.wang@mediatek.com, vince-wl.liu@mediatek.com,
jh.hsu@mediatek.com
Subject: Re: [PATCH 2/4] dt-bindings: media: mediatek-jpeg-decoder: add MT8189 compatible string
Date: Fri, 12 Dec 2025 04:16:28 +0100 [thread overview]
Message-ID: <a2810e51-1c59-46be-aa3a-411149001c70@kernel.org> (raw)
In-Reply-To: <20251212015218.4689-3-jianhua.lin@mediatek.com>
On 12/12/2025 02:52, Jianhua Lin wrote:
> Compared to the previous generation IC, the MT8189 uses 34-bit
> iova address-space. Therefore, add "mediatek,mt8189-jpgdec"
> compatible to the binding document.
>
> Signed-off-by: Jianhua Lin <jianhua.lin@mediatek.com>
> ---
> .../bindings/media/mediatek-jpeg-decoder.yaml | 46 +++++++++++++++++--
> 1 file changed, 41 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml
> index a4aacd3eb189..935a908465c8 100644
> --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml
> @@ -19,11 +19,15 @@ properties:
> - enum:
> - mediatek,mt8173-jpgdec
> - mediatek,mt2701-jpgdec
> + - mediatek,mt8189-jpgdec
> - items:
> - enum:
> - mediatek,mt7623-jpgdec
> - - mediatek,mt8188-jpgdec
That's ABI beak completely unexplained in the commit msg.
No, please read carefully writing bindings doc before posting next DT patch.
I am not reviewing the rest.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-12 3:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 1:52 [PATCH 0/4] Mediatek MT8189 JPEG support Jianhua Lin
2025-12-12 1:52 ` [PATCH 1/4] arm64: dts: mt8188: update JPEG encoder/decoder compatible Jianhua Lin
2025-12-12 1:52 ` [PATCH 2/4] dt-bindings: media: mediatek-jpeg-decoder: add MT8189 compatible string Jianhua Lin
2025-12-12 3:16 ` Krzysztof Kozlowski [this message]
2025-12-12 1:52 ` [PATCH 3/4] dt-bindings: media: mediatek-jpeg-encoder: " Jianhua Lin
2025-12-12 3:18 ` Krzysztof Kozlowski
2025-12-12 1:52 ` [PATCH 4/4] media: mediatek: jpeg: add compatible for MT8189 SoC Jianhua Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2810e51-1c59-46be-aa3a-411149001c70@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jh.hsu@mediatek.com \
--cc=jianhua.lin@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sirius.wang@mediatek.com \
--cc=vince-wl.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox