public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Ian Rogers <irogers@google.com>
Cc: John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linux.dev>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Akio Kakuno <fj3333bs@aa.jp.fujitsu.com>,
	Yoshihiro Furudera <fj5100bi@fujitsu.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf vendor events arm64: Remove uncountable events
Date: Sat, 3 Jan 2026 16:38:12 +0000	[thread overview]
Message-ID: <951f10c5-e1ac-45d4-b7ca-56aa32e57cd6@linaro.org> (raw)
In-Reply-To: <CAP-5=fUNJLoy25rS=diSXNR9h-h4m6EFPTy8M+KpTKxm6HtDSA@mail.gmail.com>



On 02/01/2026 3:29 pm, Ian Rogers wrote:
> On Wed, Dec 31, 2025 at 4:13 AM James Clark <james.clark@linaro.org> wrote:
>>
>> These events are never countable by the PMU and are only intended to
>> be used as external inputs to trace. Therefore showing them in 'perf
>> list' is misleading so remove them.
> 
> What does "trace" mean in this context?
> 

CPU trace, Either ETE (Embedded Trace Extension) or ETM (Embedded Trace 
Macrocell). You can select PMU events as inputs to the trace block to 
make it do things like start and stop tracing.

> Thanks,
> Ian
> 
>> The generator script doesn't emit these events when used with the new
>> telemetry-solution input files [1].
>>
>> 'perf list' should only show countable events because there are events
>> that are sometimes implemented, sometimes countable and sometimes not,
>> for example TRB_TRIG. If we always include any implemented events
>> whether they are countable or not then it's not possible to tell whether
>> they are usable in perf without going to the docs, defeating the point
>> of 'perf list'.
>>
>> It's also not useful yet to display implemented events that are not
>> countable (for help in using trace rather than perf stat), because
>> PMU_OVFS and PMU_HOVFS are practically always implemented and TRB_TRIG
>> is always implemented when there is TRBE.
>>
>> [1]: https://gitlab.arm.com/telemetry-solution/telemetry-solution/-/tree/main/data/pmu/cpu
>>
>> Signed-off-by: James Clark <james.clark@linaro.org>
>> ---
>>   tools/perf/pmu-events/arch/arm64/arm/cortex-a510/pmu.json  |  8 --------
>>   tools/perf/pmu-events/arch/arm64/common-and-microarch.json | 12 ------------
>>   tools/perf/pmu-events/arch/arm64/fujitsu/monaka/pmu.json   | 10 ----------
>>   3 files changed, 30 deletions(-)
>>
>> diff --git a/tools/perf/pmu-events/arch/arm64/arm/cortex-a510/pmu.json b/tools/perf/pmu-events/arch/arm64/arm/cortex-a510/pmu.json
>> deleted file mode 100644
>> index d8b7b9f9e5fa..000000000000
>> --- a/tools/perf/pmu-events/arch/arm64/arm/cortex-a510/pmu.json
>> +++ /dev/null
>> @@ -1,8 +0,0 @@
>> -[
>> -    {
>> -        "ArchStdEvent": "PMU_OVFS"
>> -    },
>> -    {
>> -        "ArchStdEvent": "PMU_HOVFS"
>> -    }
>> -]
>> diff --git a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
>> index 2416d9f8a83d..468cb085d879 100644
>> --- a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
>> +++ b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
>> @@ -432,24 +432,12 @@
>>           "EventName": "TRB_WRAP",
>>           "BriefDescription": "Trace buffer current write pointer wrapped"
>>       },
>> -    {
>> -        "PublicDescription": "PMU overflow, counters accessible to EL1 and EL0",
>> -        "EventCode": "0x400D",
>> -        "EventName": "PMU_OVFS",
>> -        "BriefDescription": "PMU overflow, counters accessible to EL1 and EL0"
>> -    },
>>       {
>>           "PublicDescription": "Trace buffer Trigger Event",
>>           "EventCode": "0x400E",
>>           "EventName": "TRB_TRIG",
>>           "BriefDescription": "Trace buffer Trigger Event"
>>       },
>> -    {
>> -        "PublicDescription": "PMU overflow, counters reserved for use by EL2",
>> -        "EventCode": "0x400F",
>> -        "EventName": "PMU_HOVFS",
>> -        "BriefDescription": "PMU overflow, counters reserved for use by EL2"
>> -    },
>>       {
>>           "PublicDescription": "PE Trace Unit external output 0",
>>           "EventCode": "0x4010",
>> diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/monaka/pmu.json b/tools/perf/pmu-events/arch/arm64/fujitsu/monaka/pmu.json
>> deleted file mode 100644
>> index 65bd6cdd0dd5..000000000000
>> --- a/tools/perf/pmu-events/arch/arm64/fujitsu/monaka/pmu.json
>> +++ /dev/null
>> @@ -1,10 +0,0 @@
>> -[
>> -    {
>> -        "ArchStdEvent": "PMU_OVFS",
>> -        "BriefDescription": "This event counts the event generated each time one of the condition occurs described in Arm Architecture Reference Manual for A-profile architecture. This event is only for output to the trace unit."
>> -    },
>> -    {
>> -        "ArchStdEvent": "PMU_HOVFS",
>> -        "BriefDescription": "This event counts the event generated each time an event is counted by an event counter <n> and all of the condition occur described in Arm Architecture Reference Manual for A-profile architecture. This event is only for output to the trace unit."
>> -    }
>> -]
>>
>> ---
>> base-commit: cbd41c6d4c26c161a2b0e70ad411d3885ff13507
>> change-id: 20251230-james-perf-uncountable-events-28adfb93b73f
>>
>> Best regards,
>> --
>> James Clark <james.clark@linaro.org>
>>


  reply	other threads:[~2026-01-03 16:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31 12:12 [PATCH] perf vendor events arm64: Remove uncountable events James Clark
2026-01-02 15:29 ` Ian Rogers
2026-01-03 16:38   ` James Clark [this message]
2026-01-04  1:27     ` Ian Rogers
2026-01-05 10:23       ` James Clark
2026-01-13 20:32       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=951f10c5-e1ac-45d4-b7ca-56aa32e57cd6@linaro.org \
    --to=james.clark@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=fj3333bs@aa.jp.fujitsu.com \
    --cc=fj5100bi@fujitsu.com \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox