* [PATCH next] dmaengine: idxd: init: Fix uninitialized use of conf_dev in idxd_setup_wqs()
@ 2025-07-28 11:51 Ziming Du
2025-07-28 14:56 ` Dave Jiang
0 siblings, 1 reply; 3+ messages in thread
From: Ziming Du @ 2025-07-28 11:51 UTC (permalink / raw)
To: dmaengine; +Cc: linux-kernel, vkoul, dave.jiang, vinicius.gomes, liuyongqiang13
Fix Smatch-detected issue:
drivers/dma/idxd/init.c:246 idxd_setup_wqs() error:
uninitialized symbol'conf_dev'
'conf_dev' may be used uninitialized in error handling paths.
Specifically, if the memory allocation for 'wq' fails, the code
jumps to 'err', and attempt to call put_device(conf_dev), without
ensuring that conf_dev has been properly initialized.
Fix it by initializing conf_dev to NULL at declaration.
Signed-off-by: Ziming Du <duziming2@huawei.com>
---
drivers/dma/idxd/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 35bdefd3728b..2b61f26af1f6 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -178,7 +178,7 @@ static int idxd_setup_wqs(struct idxd_device *idxd)
{
struct device *dev = &idxd->pdev->dev;
struct idxd_wq *wq;
- struct device *conf_dev;
+ struct device *conf_dev = NULL;
int i, rc;
idxd->wqs = kcalloc_node(idxd->max_wqs, sizeof(struct idxd_wq *),
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] dmaengine: idxd: init: Fix uninitialized use of conf_dev in idxd_setup_wqs()
2025-07-28 11:51 [PATCH next] dmaengine: idxd: init: Fix uninitialized use of conf_dev in idxd_setup_wqs() Ziming Du
@ 2025-07-28 14:56 ` Dave Jiang
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2025-07-28 14:56 UTC (permalink / raw)
To: Ziming Du, dmaengine; +Cc: linux-kernel, vkoul, vinicius.gomes, liuyongqiang13
On 7/28/25 4:51 AM, Ziming Du wrote:
> Fix Smatch-detected issue:
> drivers/dma/idxd/init.c:246 idxd_setup_wqs() error:
> uninitialized symbol'conf_dev'
>
> 'conf_dev' may be used uninitialized in error handling paths.
> Specifically, if the memory allocation for 'wq' fails, the code
> jumps to 'err', and attempt to call put_device(conf_dev), without
> ensuring that conf_dev has been properly initialized.
>
> Fix it by initializing conf_dev to NULL at declaration.
>
> Signed-off-by: Ziming Du <duziming2@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 35bdefd3728b..2b61f26af1f6 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -178,7 +178,7 @@ static int idxd_setup_wqs(struct idxd_device *idxd)
> {
> struct device *dev = &idxd->pdev->dev;
> struct idxd_wq *wq;
> - struct device *conf_dev;
> + struct device *conf_dev = NULL;
> int i, rc;
>
> idxd->wqs = kcalloc_node(idxd->max_wqs, sizeof(struct idxd_wq *),
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH next] dmaengine: idxd: init: Fix uninitialized use of conf_dev in idxd_setup_wqs()
@ 2025-07-28 11:36 Ziming Du
0 siblings, 0 replies; 3+ messages in thread
From: Ziming Du @ 2025-07-28 11:36 UTC (permalink / raw)
To: linux-kernel; +Cc: dmaengine, vkoul, dave.jiang, vinicius.gomes, liuyongqiang13
Fix Smatch-detected issue:
drivers/dma/idxd/init.c:246 idxd_setup_wqs() error:
uninitialized symbol'conf_dev'
'conf_dev' may be used uninitialized in error handling paths.
Specifically, if the memory allocation for 'wq' fails, the code
jumps to 'err', and attempt to call put_device(conf_dev), without
ensuring that conf_dev has been properly initialized.
Fix it by initializing conf_dev to NULL at declaration.
Signed-off-by: Ziming Du <duziming2@huawei.com>
---
drivers/dma/idxd/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 35bdefd3728b..2b61f26af1f6 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -178,7 +178,7 @@ static int idxd_setup_wqs(struct idxd_device *idxd)
{
struct device *dev = &idxd->pdev->dev;
struct idxd_wq *wq;
- struct device *conf_dev;
+ struct device *conf_dev = NULL;
int i, rc;
idxd->wqs = kcalloc_node(idxd->max_wqs, sizeof(struct idxd_wq *),
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-28 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-28 11:51 [PATCH next] dmaengine: idxd: init: Fix uninitialized use of conf_dev in idxd_setup_wqs() Ziming Du
2025-07-28 14:56 ` Dave Jiang
-- strict thread matches above, loose matches on Subject: below --
2025-07-28 11:36 Ziming Du
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox