From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: rt5682: Add jack kcontrol
Date: Fri, 8 Apr 2022 00:46:04 +0900 [thread overview]
Message-ID: <96dae189-c0ff-4054-3d00-41c3b44c2cd6@gmail.com> (raw)
In-Reply-To: <Yk7+jbQ0KBM0zVh9@sirena.org.uk>
On 2022/04/08 0:09, Mark Brown wrote:
> On Thu, Apr 07, 2022 at 11:13:16PM +0900, Akihiko Odaki wrote:
>
>> Create a jack kcontrol manually as rt5682 does not use DAPM pins
>> for jack and will not have kcontrols for them.
>
> Why not use DAPM for the jack? Note that normally the jack is part of
> the machine driver not the CODEC - there's no way the CODEC can know how
> it's been wired in on any given system.
It seems it is an unsual case where the codec knows the source of the
jack. RT5682 has interrupts and registers for the jack; see e.g.
rt5682_button_detect in sound/soc/codecs/rt5682.c for details.
Regards,
Akihiko Odaki
next prev parent reply other threads:[~2022-04-07 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:13 [PATCH] ASoC: rt5682: Add jack kcontrol Akihiko Odaki
2022-04-07 15:09 ` Mark Brown
2022-04-07 15:46 ` Akihiko Odaki [this message]
2022-04-07 16:00 ` Mark Brown
2022-04-07 16:11 ` Akihiko Odaki
2022-04-07 16:37 ` Mark Brown
2022-04-07 17:16 ` Akihiko Odaki
2022-04-07 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96dae189-c0ff-4054-3d00-41c3b44c2cd6@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox