* [PATCH] mmc: sdhci-of-arasan: Increase CD stable timeout to 2 seconds
@ 2025-12-12 6:35 Sai Krishna Potthuri
2025-12-12 11:17 ` Adrian Hunter
2025-12-17 13:45 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Sai Krishna Potthuri @ 2025-12-12 6:35 UTC (permalink / raw)
To: Adrian Hunter, Michal Simek, Ulf Hansson
Cc: linux-mmc, linux-arm-kernel, linux-kernel, git, saikrishna12468,
Sai Krishna Potthuri
On Xilinx/AMD platforms, the CD stable bit take slightly longer than
one second(about an additional 100ms) to assert after a host
controller reset. Although no functional failure observed with the
existing one second delay but to ensure reliable initialization, increase
the CD stable timeout to 2 seconds.
Fixes: e251709aaddb ("mmc: sdhci-of-arasan: Ensure CD logic stabilization before power-up")
Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index b97d042897ad..ab7f0ffe7b4f 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -99,7 +99,7 @@
#define HIWORD_UPDATE(val, mask, shift) \
((val) << (shift) | (mask) << ((shift) + 16))
-#define CD_STABLE_TIMEOUT_US 1000000
+#define CD_STABLE_TIMEOUT_US 2000000
#define CD_STABLE_MAX_SLEEP_US 10
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-of-arasan: Increase CD stable timeout to 2 seconds
2025-12-12 6:35 [PATCH] mmc: sdhci-of-arasan: Increase CD stable timeout to 2 seconds Sai Krishna Potthuri
@ 2025-12-12 11:17 ` Adrian Hunter
2025-12-17 13:45 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2025-12-12 11:17 UTC (permalink / raw)
To: Sai Krishna Potthuri, Michal Simek, Ulf Hansson
Cc: linux-mmc, linux-arm-kernel, linux-kernel, git, saikrishna12468
On 12/12/2025 08:35, Sai Krishna Potthuri wrote:
> On Xilinx/AMD platforms, the CD stable bit take slightly longer than
> one second(about an additional 100ms) to assert after a host
> controller reset. Although no functional failure observed with the
> existing one second delay but to ensure reliable initialization, increase
> the CD stable timeout to 2 seconds.
>
> Fixes: e251709aaddb ("mmc: sdhci-of-arasan: Ensure CD logic stabilization before power-up")
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b97d042897ad..ab7f0ffe7b4f 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -99,7 +99,7 @@
> #define HIWORD_UPDATE(val, mask, shift) \
> ((val) << (shift) | (mask) << ((shift) + 16))
>
> -#define CD_STABLE_TIMEOUT_US 1000000
> +#define CD_STABLE_TIMEOUT_US 2000000
> #define CD_STABLE_MAX_SLEEP_US 10
>
> /**
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-of-arasan: Increase CD stable timeout to 2 seconds
2025-12-12 6:35 [PATCH] mmc: sdhci-of-arasan: Increase CD stable timeout to 2 seconds Sai Krishna Potthuri
2025-12-12 11:17 ` Adrian Hunter
@ 2025-12-17 13:45 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-12-17 13:45 UTC (permalink / raw)
To: Sai Krishna Potthuri
Cc: Adrian Hunter, Michal Simek, linux-mmc, linux-arm-kernel,
linux-kernel, git, saikrishna12468
On Fri, 12 Dec 2025 at 07:36, Sai Krishna Potthuri
<sai.krishna.potthuri@amd.com> wrote:
>
> On Xilinx/AMD platforms, the CD stable bit take slightly longer than
> one second(about an additional 100ms) to assert after a host
> controller reset. Although no functional failure observed with the
> existing one second delay but to ensure reliable initialization, increase
> the CD stable timeout to 2 seconds.
>
> Fixes: e251709aaddb ("mmc: sdhci-of-arasan: Ensure CD logic stabilization before power-up")
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Applied for fixes and by adding a stable-tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b97d042897ad..ab7f0ffe7b4f 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -99,7 +99,7 @@
> #define HIWORD_UPDATE(val, mask, shift) \
> ((val) << (shift) | (mask) << ((shift) + 16))
>
> -#define CD_STABLE_TIMEOUT_US 1000000
> +#define CD_STABLE_TIMEOUT_US 2000000
> #define CD_STABLE_MAX_SLEEP_US 10
>
> /**
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-17 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-12 6:35 [PATCH] mmc: sdhci-of-arasan: Increase CD stable timeout to 2 seconds Sai Krishna Potthuri
2025-12-12 11:17 ` Adrian Hunter
2025-12-17 13:45 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox