From: Yang Jihong <yangjihong1@huawei.com>
To: <tom.zanussi@linux.intel.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [QUESTION] Performance deterioration caused by commit 85f726a35e504418
Date: Mon, 18 Oct 2021 11:23:14 +0800 [thread overview]
Message-ID: <992d3b1c-70db-5cc7-8400-39caa5d502d5@huawei.com> (raw)
Hi Tom and Steven,
commit 85f726a35e504418 use strncpy instead of memcpy when copying comm,
on ARM64 machine, this commit causes performance degradation.
I test the number of instructions executed by invoking the
trace_sched_switch function once on an arm64 machine:
1. Use memcpy, the number of instructions executed is 850.
2. Use strncpy, the number of instructions executed 1100.
That is, use strncpy is almost 250 more instructions than memcpy.
Has the impact on performance been considered in this commit? :)
What is the impact of revert the patch?
Kind regards,
Jihong
next reply other threads:[~2021-10-18 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 3:23 Yang Jihong [this message]
2021-10-18 13:37 ` [QUESTION] Performance deterioration caused by commit 85f726a35e504418 Steven Rostedt
2021-10-19 2:39 ` Yang Jihong
2021-10-19 2:51 ` Steven Rostedt
2021-10-19 17:30 ` Zanussi, Tom
2021-10-19 18:10 ` Steven Rostedt
2021-10-19 18:38 ` Zanussi, Tom
2021-10-20 2:00 ` Yang Jihong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=992d3b1c-70db-5cc7-8400-39caa5d502d5@huawei.com \
--to=yangjihong1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox