From: "Zanussi, Tom" <tom.zanussi@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Yang Jihong <yangjihong1@huawei.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [QUESTION] Performance deterioration caused by commit 85f726a35e504418
Date: Tue, 19 Oct 2021 13:38:37 -0500 [thread overview]
Message-ID: <ea059f74-95d8-3e33-fbeb-02ef1ac567b0@linux.intel.com> (raw)
In-Reply-To: <20211019141002.386e7b6a@gandalf.local.home>
On 10/19/2021 1:10 PM, Steven Rostedt wrote:
> On Tue, 19 Oct 2021 12:30:28 -0500
> "Zanussi, Tom" <tom.zanussi@linux.intel.com> wrote:
>
>> So anyway, as far as the histograms go, I think optimizing the two
>> changes in 85f726a35e504418 while ignoring trailing garbage can be done
>> without affecting the histogram correctness.
>
> So, none of that is exported to user space?
I meant just that any optimization of those two things that ignored the
trailing garbage wouldn't affect the histogram keys.
But yeah I think you're correct that ignoring it in the case of
saved_cmdlines wouldn't be a problem either but it would be in the case of
max_buffer since that's exported by the ring buffer.
Tom
>
> -- Steve
>
next prev parent reply other threads:[~2021-10-19 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 3:23 [QUESTION] Performance deterioration caused by commit 85f726a35e504418 Yang Jihong
2021-10-18 13:37 ` Steven Rostedt
2021-10-19 2:39 ` Yang Jihong
2021-10-19 2:51 ` Steven Rostedt
2021-10-19 17:30 ` Zanussi, Tom
2021-10-19 18:10 ` Steven Rostedt
2021-10-19 18:38 ` Zanussi, Tom [this message]
2021-10-20 2:00 ` Yang Jihong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea059f74-95d8-3e33-fbeb-02ef1ac567b0@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox