From: Markus Elfring <Markus.Elfring@web.de>
To: Osama Abdelkader <osama.abdelkader@gmail.com>,
kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
kvm@vger.kernel.org
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: riscv: kvm: fix vector context allocation leak
Date: Mon, 16 Mar 2026 17:36:55 +0100 [thread overview]
Message-ID: <9b504811-0998-4879-8ab9-bbcaa423555f@web.de> (raw)
In-Reply-To: <abggnCAb9Py60PBT@osama>
>>> When the second kzalloc (host_context.vector.datap) fails in
>>> kvm_riscv_vcpu_alloc_vector_context, the first allocation
>>> (guest_context.vector.datap) is leaked. Free it before returning.
>> Were any source code analysis tools involved here?
>>
> No, there were found during manual review.
Would be looking for the support of advanced approaches
which would make such a “inspection” more convenient?
Regards,
Markus
prev parent reply other threads:[~2026-03-16 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 22:31 [PATCH] riscv: kvm: fix vector context allocation leak Osama Abdelkader
2026-03-16 9:23 ` Markus Elfring
2026-03-16 15:24 ` Osama Abdelkader
2026-03-16 16:36 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b504811-0998-4879-8ab9-bbcaa423555f@web.de \
--to=markus.elfring@web.de \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=osama.abdelkader@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox