* [PATCH] drm/panel: ili9341: Remove a superfluous else after return
@ 2024-04-29 17:12 Sui Jingfeng
2024-04-29 23:10 ` Jessica Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Sui Jingfeng @ 2024-04-29 17:12 UTC (permalink / raw)
To: Neil Armstrong
Cc: Jessica Zhang, Sam Ravnborg, Maarten Lankhorst, Thomas Zimmermann,
David Airlie, Daniel Vetter, dri-devel, linux-kernel,
Sui Jingfeng
The else clause after the ruturn clause is not useful.
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 3574681891e8..433572c4caf9 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)
if (!strcmp(id->name, "sf-tc240t-9370-t"))
return ili9341_dpi_probe(spi, dc, reset);
- else if (!strcmp(id->name, "yx240qv29"))
+
+ if (!strcmp(id->name, "yx240qv29"))
return ili9341_dbi_probe(spi, dc, reset);
return -1;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return
2024-04-29 17:12 [PATCH] drm/panel: ili9341: Remove a superfluous else after return Sui Jingfeng
@ 2024-04-29 23:10 ` Jessica Zhang
2024-04-30 17:00 ` Sui Jingfeng
0 siblings, 1 reply; 3+ messages in thread
From: Jessica Zhang @ 2024-04-29 23:10 UTC (permalink / raw)
To: Sui Jingfeng, Neil Armstrong
Cc: Sam Ravnborg, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
> The else clause after the ruturn clause is not useful.
Hi Sui,
Spelling nit: ruturn --> return
Besides that,
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
>
> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index 3574681891e8..433572c4caf9 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)
>
> if (!strcmp(id->name, "sf-tc240t-9370-t"))
> return ili9341_dpi_probe(spi, dc, reset);
> - else if (!strcmp(id->name, "yx240qv29"))
> +
> + if (!strcmp(id->name, "yx240qv29"))
> return ili9341_dbi_probe(spi, dc, reset);
>
> return -1;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return
2024-04-29 23:10 ` Jessica Zhang
@ 2024-04-30 17:00 ` Sui Jingfeng
0 siblings, 0 replies; 3+ messages in thread
From: Sui Jingfeng @ 2024-04-30 17:00 UTC (permalink / raw)
To: Jessica Zhang, Neil Armstrong
Cc: Sam Ravnborg, Maarten Lankhorst, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
Hi,
On 2024/4/30 07:10, Jessica Zhang wrote:
>
>
> On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
>> The else clause after the ruturn clause is not useful.
>
> Hi Sui,
>
> Spelling nit: ruturn --> return
>
Thanks for pointed out, will be fixed.
> Besides that,
>
> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>
> Thanks,
>
> Jessica Zhang
Thanks, Jessica.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-30 17:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 17:12 [PATCH] drm/panel: ili9341: Remove a superfluous else after return Sui Jingfeng
2024-04-29 23:10 ` Jessica Zhang
2024-04-30 17:00 ` Sui Jingfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox