From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mathias Nyman <mathias.nyman@intel.com>
Subject: Re: [PATCH v1 1/2] xhci: pci: Use standard pattern for device IDs
Date: Fri, 13 Sep 2024 11:51:48 +0300 [thread overview]
Message-ID: <9ccea075-5724-3a9c-738f-03eb2d519c45@gmail.com> (raw)
In-Reply-To: <20240913084411.3309911-2-andriy.shevchenko@linux.intel.com>
On 9/13/24 11:43 AM, Andy Shevchenko wrote:
> The definitions of vendor IDs are follow the pattern
s/are//?
> PCI_VENDOR_ID_#vendor, while device IDs — PCI_DEVICE_ID_#vendor_#device.
>
> Update the ETRON device IDs to follow the above mentioned pattern.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[...]
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index de50f5ba60df..6d9eb2b031e2 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
[...]
> @@ -388,12 +388,12 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
>
> if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> - pdev->device == PCI_DEVICE_ID_EJ168) {
> + pdev->device == PCI_DEVICE_ID_ETRON_EJ168) {
> xhci->quirks |= XHCI_RESET_ON_RESUME;
> xhci->quirks |= XHCI_BROKEN_STREAMS;
> }
> if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> - pdev->device == PCI_DEVICE_ID_EJ188) {
> + pdev->device == PCI_DEVICE_ID_ETRON_EJ188) {
> xhci->quirks |= XHCI_RESET_ON_RESUME;
> xhci->quirks |= XHCI_BROKEN_STREAMS;
>
Hm, these 2 *if*s seem mergeable?
MBR, Sergey
next prev parent reply other threads:[~2024-09-13 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 8:43 [PATCH v1 0/2] xhci: pci: Amend definitions of PCI device IDs Andy Shevchenko
2024-09-13 8:43 ` [PATCH v1 1/2] xhci: pci: Use standard pattern for " Andy Shevchenko
2024-09-13 8:51 ` Sergei Shtylyov [this message]
2024-09-13 9:42 ` Andy Shevchenko
2024-09-13 8:43 ` [PATCH v1 2/2] xhci: pci: Fix indentation in the PCI device ID definitions Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ccea075-5724-3a9c-738f-03eb2d519c45@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox