Re: [PATCH v1 1/2] xhci: pci: Use standard pattern for device IDs

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, Sep 13, 2024 at 11:51:48AM +0300, Sergei Shtylyov wrote:
> On 9/13/24 11:43 AM, Andy Shevchenko wrote:
> 
> > The definitions of vendor IDs are follow the pattern
> 
>    s/are//?

Yeah, thank you for catching this.

> > PCI_VENDOR_ID_#vendor, while device IDs — PCI_DEVICE_ID_#vendor_#device.
> > 
> > Update the ETRON device IDs to follow the above mentioned pattern.

[...]

> >  	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> > -			pdev->device == PCI_DEVICE_ID_EJ168) {
> > +	    pdev->device == PCI_DEVICE_ID_ETRON_EJ168) {
> >  		xhci->quirks |= XHCI_RESET_ON_RESUME;
> >  		xhci->quirks |= XHCI_BROKEN_STREAMS;
> >  	}
> >  	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> > -			pdev->device == PCI_DEVICE_ID_EJ188) {
> > +	    pdev->device == PCI_DEVICE_ID_ETRON_EJ188) {
> >  		xhci->quirks |= XHCI_RESET_ON_RESUME;
> >  		xhci->quirks |= XHCI_BROKEN_STREAMS;
> 
>    Hm, these 2 *if*s seem mergeable?

It's out of the scope of this mini-series, but seems a good catch!

-- 
With Best Regards,
Andy Shevchenko