From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Krishna Chaitanya Chundru" <quic_krichai@quicinc.com>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
konrad.dybcio@oss.qualcomm.com, quic_mrana@quicinc.com,
quic_vbadigan@quicinc.com, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH v2 1/4] arm64: dts: qcom: x1e80100: Add PCIe lane equalization preset properties
Date: Thu, 12 Dec 2024 13:37:57 +0100 [thread overview]
Message-ID: <9ceb9f9d-633d-49e6-ab1b-1db739e4f2a4@kernel.org> (raw)
In-Reply-To: <bd9d0b2b-cb69-3a20-8ae6-125c7010c1e5@quicinc.com>
On 12/12/2024 13:32, Krishna Chaitanya Chundru wrote:
>> 2. There are no such properties. It does not look like you tested the
>> DTS against bindings. Please run `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
> The property is added recently in to the dtschema in github repo, I
> added the pull request details in the cover letter, I will add the
> github link as part of the comment section for this patch in next
> series.
>
Mention in the commit msg or cover letter where are the bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-12 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 10:32 [PATCH v2 0/4] PCI: dwc: Add support for configuring lane equalization presets Krishna Chaitanya Chundru
2024-12-12 10:32 ` [PATCH v2 1/4] arm64: dts: qcom: x1e80100: Add PCIe lane equalization preset properties Krishna Chaitanya Chundru
2024-12-12 12:25 ` Krzysztof Kozlowski
2024-12-12 12:32 ` Krishna Chaitanya Chundru
2024-12-12 12:37 ` Krzysztof Kozlowski [this message]
2024-12-12 10:32 ` [PATCH v2 2/4] PCI: of: Add API to retrieve equalization presets from device tree Krishna Chaitanya Chundru
2024-12-12 10:32 ` [PATCH v2 3/4] PCI: dwc: Improve handling of PCIe lane configuration Krishna Chaitanya Chundru
2024-12-12 10:32 ` [PATCH v2 4/4] PCI: dwc: Add support for new pci function op Krishna Chaitanya Chundru
2024-12-12 10:40 ` [PATCH v2 0/4] PCI: dwc: Add support for configuring lane equalization presets Krishna Chaitanya Chundru
2024-12-12 12:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ceb9f9d-633d-49e6-ab1b-1db739e4f2a4@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox