From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
kernel@collabora.com, Aishwarya TCV <aishwarya.tcv@arm.com>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
Date: Wed, 29 Nov 2023 16:34:34 +0500 [thread overview]
Message-ID: <9dbda2f9-2bb2-4e79-976a-12856ab6936a@collabora.com> (raw)
In-Reply-To: <20231024155137.219700-1-usama.anjum@collabora.com>
Soft reminder
On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
> Correct header file is needed for getting CLOSE_RANGE_* macros.
> Previously it was tested with newer glibc which didn't show the need to
> include the header which was a mistake.
>
> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/core/close_range_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
> index 534576f06df1c..c59e4adb905df 100644
> --- a/tools/testing/selftests/core/close_range_test.c
> +++ b/tools/testing/selftests/core/close_range_test.c
> @@ -12,6 +12,7 @@
> #include <syscall.h>
> #include <unistd.h>
> #include <sys/resource.h>
> +#include <linux/close_range.h>
>
> #include "../kselftest_harness.h"
> #include "../clone3/clone3_selftests.h"
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2023-11-29 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 15:51 [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros Muhammad Usama Anjum
2023-11-29 11:34 ` Muhammad Usama Anjum [this message]
2023-12-11 11:01 ` Muhammad Usama Anjum
2024-01-05 9:25 ` Muhammad Usama Anjum
2024-01-23 7:54 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dbda2f9-2bb2-4e79-976a-12856ab6936a@collabora.com \
--to=usama.anjum@collabora.com \
--cc=aishwarya.tcv@arm.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox