The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
@ 2023-10-24 15:51 Muhammad Usama Anjum
  2023-11-29 11:34 ` Muhammad Usama Anjum
  2024-01-23  7:54 ` Muhammad Usama Anjum
  0 siblings, 2 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2023-10-24 15:51 UTC (permalink / raw)
  To: Shuah Khan, Muhammad Usama Anjum
  Cc: kernel, Aishwarya TCV, Shuah Khan, linux-kselftest, linux-kernel

Correct header file is needed for getting CLOSE_RANGE_* macros.
Previously it was tested with newer glibc which didn't show the need to
include the header which was a mistake.

Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/core/close_range_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
index 534576f06df1c..c59e4adb905df 100644
--- a/tools/testing/selftests/core/close_range_test.c
+++ b/tools/testing/selftests/core/close_range_test.c
@@ -12,6 +12,7 @@
 #include <syscall.h>
 #include <unistd.h>
 #include <sys/resource.h>
+#include <linux/close_range.h>
 
 #include "../kselftest_harness.h"
 #include "../clone3/clone3_selftests.h"
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
  2023-10-24 15:51 [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros Muhammad Usama Anjum
@ 2023-11-29 11:34 ` Muhammad Usama Anjum
  2023-12-11 11:01   ` Muhammad Usama Anjum
  2024-01-23  7:54 ` Muhammad Usama Anjum
  1 sibling, 1 reply; 5+ messages in thread
From: Muhammad Usama Anjum @ 2023-11-29 11:34 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Muhammad Usama Anjum, kernel, Aishwarya TCV, Shuah Khan,
	linux-kselftest, linux-kernel

Soft reminder

On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
> Correct header file is needed for getting CLOSE_RANGE_* macros.
> Previously it was tested with newer glibc which didn't show the need to
> include the header which was a mistake.
> 
> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  tools/testing/selftests/core/close_range_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
> index 534576f06df1c..c59e4adb905df 100644
> --- a/tools/testing/selftests/core/close_range_test.c
> +++ b/tools/testing/selftests/core/close_range_test.c
> @@ -12,6 +12,7 @@
>  #include <syscall.h>
>  #include <unistd.h>
>  #include <sys/resource.h>
> +#include <linux/close_range.h>
>  
>  #include "../kselftest_harness.h"
>  #include "../clone3/clone3_selftests.h"

-- 
BR,
Muhammad Usama Anjum

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
  2023-11-29 11:34 ` Muhammad Usama Anjum
@ 2023-12-11 11:01   ` Muhammad Usama Anjum
  2024-01-05  9:25     ` Muhammad Usama Anjum
  0 siblings, 1 reply; 5+ messages in thread
From: Muhammad Usama Anjum @ 2023-12-11 11:01 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Muhammad Usama Anjum, kernel, Aishwarya TCV, Shuah Khan,
	linux-kselftest, linux-kernel

Soft reminder

On 11/29/23 4:34 PM, Muhammad Usama Anjum wrote:
> Soft reminder
> 
> On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
>> Correct header file is needed for getting CLOSE_RANGE_* macros.
>> Previously it was tested with newer glibc which didn't show the need to
>> include the header which was a mistake.
>>
>> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
>> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
>> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>>  tools/testing/selftests/core/close_range_test.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
>> index 534576f06df1c..c59e4adb905df 100644
>> --- a/tools/testing/selftests/core/close_range_test.c
>> +++ b/tools/testing/selftests/core/close_range_test.c
>> @@ -12,6 +12,7 @@
>>  #include <syscall.h>
>>  #include <unistd.h>
>>  #include <sys/resource.h>
>> +#include <linux/close_range.h>
>>  
>>  #include "../kselftest_harness.h"
>>  #include "../clone3/clone3_selftests.h"
> 

-- 
BR,
Muhammad Usama Anjum

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
  2023-12-11 11:01   ` Muhammad Usama Anjum
@ 2024-01-05  9:25     ` Muhammad Usama Anjum
  0 siblings, 0 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2024-01-05  9:25 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Muhammad Usama Anjum, kernel, Aishwarya TCV, Shuah Khan,
	linux-kselftest, linux-kernel

Kind reminder

On 12/11/23 4:01 PM, Muhammad Usama Anjum wrote:
> Soft reminder
> 
> On 11/29/23 4:34 PM, Muhammad Usama Anjum wrote:
>> Soft reminder
>>
>> On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
>>> Correct header file is needed for getting CLOSE_RANGE_* macros.
>>> Previously it was tested with newer glibc which didn't show the need to
>>> include the header which was a mistake.
>>>
>>> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
>>> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
>>> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>>  tools/testing/selftests/core/close_range_test.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
>>> index 534576f06df1c..c59e4adb905df 100644
>>> --- a/tools/testing/selftests/core/close_range_test.c
>>> +++ b/tools/testing/selftests/core/close_range_test.c
>>> @@ -12,6 +12,7 @@
>>>  #include <syscall.h>
>>>  #include <unistd.h>
>>>  #include <sys/resource.h>
>>> +#include <linux/close_range.h>
>>>  
>>>  #include "../kselftest_harness.h"
>>>  #include "../clone3/clone3_selftests.h"
>>
> 

-- 
BR,
Muhammad Usama Anjum

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
  2023-10-24 15:51 [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros Muhammad Usama Anjum
  2023-11-29 11:34 ` Muhammad Usama Anjum
@ 2024-01-23  7:54 ` Muhammad Usama Anjum
  1 sibling, 0 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2024-01-23  7:54 UTC (permalink / raw)
  To: Shuah Khan, Shuah Khan
  Cc: Muhammad Usama Anjum, kernel, Aishwarya TCV, linux-kselftest,
	linux-kernel, Andrew Morton

Hi,

Can anybody please pick this patch? This was fixing genuine regression in
some build system.

Thanks,

On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
> Correct header file is needed for getting CLOSE_RANGE_* macros.
> Previously it was tested with newer glibc which didn't show the need to
> include the header which was a mistake.
> 
> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  tools/testing/selftests/core/close_range_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
> index 534576f06df1c..c59e4adb905df 100644
> --- a/tools/testing/selftests/core/close_range_test.c
> +++ b/tools/testing/selftests/core/close_range_test.c
> @@ -12,6 +12,7 @@
>  #include <syscall.h>
>  #include <unistd.h>
>  #include <sys/resource.h>
> +#include <linux/close_range.h>
>  
>  #include "../kselftest_harness.h"
>  #include "../clone3/clone3_selftests.h"

-- 
BR,
Muhammad Usama Anjum

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-23  7:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-24 15:51 [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros Muhammad Usama Anjum
2023-11-29 11:34 ` Muhammad Usama Anjum
2023-12-11 11:01   ` Muhammad Usama Anjum
2024-01-05  9:25     ` Muhammad Usama Anjum
2024-01-23  7:54 ` Muhammad Usama Anjum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox