From: Jay Dolan <jay.dolan@accesio.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/2] serial: 8250_pci: Split out Pericom driver
Date: Thu, 18 Nov 2021 06:45:46 -0800 [thread overview]
Message-ID: <9fcd2bbf-069b-aae5-07e2-e1faa9aa6428@accesio.com> (raw)
In-Reply-To: <CAHp75VfDPuPbvRsfKX2+0NT0K36-+xzDA2QscXD5Wcta1Q5zuQ@mail.gmail.com>
On 11/18/21 1:50 AM, Andy Shevchenko wrote:
> On Thu, Nov 18, 2021 at 4:39 AM Jay Dolan <jay.dolan@accesio.com> wrote:
>> On 11/17/21 6:57 AM, Andy Shevchenko wrote:
>
> Thanks for looking into it. My answer below.
>
> ...
>
>>> + for (i = 0; i < nr && i < maxnr; i++) {
>>> + unsigned int offset = (i == 3 && nr == 4) ? 0x38 : i * 0x8;
>> I'm told this works for PCIe ACCES PIDS, but the PCI PIDs don't have the
>> fourth port at the wrong address. I didn't know this until just now.
>
> For the sake of context I left below PCI IDs, all of them have PCIE
> prefix. Moreover, the patch should not change this logic (see
> different setup functions in the original code). So if it wasn't
> working it is not working anyway. Besides that, what does the above
> mean? The ID can't be the same for two different hardware.You're right. I think I was confused first. I sent the list of PIDs to
someone who knows all the products to verify. Either way I will get this
tested tonight.
>
>> I've never had reason to try and tell if a pci_dev is PCI or PCIe. Can
>> we query capabilities?
>
> This is confusing me. What does all this imply?
>
>> It may also be possible to tell by the size of
>> one of the BARs.
>
> This is already done by calculating maxnr.
>
>> I've requested a four port PCI card and should have it
>> tomorrow.
>
> I'm looking forward to seeing any test results.
>
>> I'm currently building the previous patch set for testing.
>
> Noted, thanks!
>
> ...
>
>>> + { PCI_VDEVICE(PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7951) },
>>> + { PCI_VDEVICE(PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7952) },
>>> + { PCI_VDEVICE(PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7954) },
>>> + { PCI_VDEVICE(PERICOM, PCI_DEVICE_ID_PERICOM_PI7C9X7958) },
>>> +
>>> + /*
>>> + * ACCES I/O Products quad
>>> + * (Only 7954 has an offset jump for port 4)
>>> + */
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM_2SDB) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_COM_2S) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM422_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM485_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM_4SDB) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_COM_4S) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM422_8) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM485_8) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM232_2DB) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_COM232_2) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM232_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM232_4DB) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_COM232_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM232_8) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM_2SMDB) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_COM_2SM) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM_4SM) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM_4SMDB) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_COM_4SM) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_COM_8SM) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM485_1) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM422_2) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM485_2) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM422_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM485_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_ICM_2S) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_ICM_4S) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_ICM232_2) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM232_2) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_ICM232_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_MPCIE_ICM232_4) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_ICM_2SM) },
>>> + { PCI_VDEVICE(ACCESSIO, PCI_DEVICE_ID_ACCESSIO_PCIE_ICM_4SM) },
>
next prev parent reply other threads:[~2021-11-18 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:57 [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver Andy Shevchenko
2021-11-17 14:57 ` [PATCH v1 1/2] serial: 8250_pci: Split out " Andy Shevchenko
2021-11-18 1:12 ` Jay Dolan
2021-11-18 9:50 ` Andy Shevchenko
2021-11-18 14:45 ` Jay Dolan [this message]
2021-11-17 14:57 ` [PATCH v1 2/2] serial: 8250_pericom: Re-enable higher baud rates Andy Shevchenko
2021-11-19 6:32 ` [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver Jay Dolan
2021-11-19 8:23 ` Andy Shevchenko
2021-11-19 14:33 ` Jay Dolan
2021-11-20 21:05 ` Jay Dolan
2021-11-21 10:16 ` Andy Shevchenko
2021-11-21 15:36 ` Jay Dolan
2021-11-22 12:47 ` Andy Shevchenko
2021-11-22 12:48 ` Andy Shevchenko
2021-11-23 5:19 ` Jay Dolan
2021-11-23 9:25 ` Andy Shevchenko
2021-11-23 15:02 ` Jay Dolan
2021-11-23 15:38 ` Andy Shevchenko
2021-11-24 4:29 ` Jay Dolan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fcd2bbf-069b-aae5-07e2-e1faa9aa6428@accesio.com \
--to=jay.dolan@accesio.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox