* Re: [PATCH] Fix regression caused by typo in lm90.c
[not found] <20070726230422.2955.70451.sendpatchset@localhost.localdomain>
@ 2007-07-27 8:07 ` Jean Delvare
2007-07-29 18:39 ` Mark M. Hoffman
2007-07-27 12:24 ` Rainer Birkenmaier
1 sibling, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2007-07-27 8:07 UTC (permalink / raw)
To: guichaz, mhoffman; +Cc: Rainer Birkenmaier, linux-kernel, lm-sensors
Hi Guillaume,
On 7/26/2007, "Guillaume Chazarain" <guichaz@yahoo.fr> wrote:
>The commit http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=32c82a934759b2c9939c9e25865c2d7d1204b9e8
>broke lm90 for my (Asus V6VA) laptop.
>
>Before 2.6.23-rc1 and with the following patch, I get:
>
>[g ~]$ sensors
>max6657-i2c-0-4c
>Adapter: SMBus I801 adapter at 0400
>M/B Temp: +64°C (low = +0°C, high = +127°C)
>CPU Temp: +78.9°C (low = +73.2°C, high = +88.2°C)
>M/B Crit: +105°C (hyst = +95°C)
>CPU Crit: +105°C (hyst = +95°C)
>
>Which regressed into:
>
>[g ~]$ sensors
>No sensors found!
>Make sure you loaded all the kernel drivers you need.
>Try sensors-detect to find out which these are.
>zsh: 2701 exit 1 sensors
>
>and dmesg contains:
>
>i2c-adapter i2c-0: Unsupported chip (man_id=0x4D, chip_id=0x4D).
>
>It seems to be a typo, as address 0X4F is mentionned nowhere else in the
>file, and my chip is actually at 0x4C.
You are right :( Sorry for missing it.
>Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
>---
>
>diff -r 4cad6fced1a8 drivers/hwmon/lm90.c
>--- a/drivers/hwmon/lm90.c Thu Jul 26 13:44:58 2007 -0700
>+++ b/drivers/hwmon/lm90.c Tue Jul 24 00:02:52 2007 +0200
>@@ -585,7 +585,7 @@ static int lm90_detect(struct i2c_adapte
> * those of the man_id register.
> */
> if (chip_id == man_id
>- && (address == 0x4F || address == 0x4D)
>+ && (address == 0x4C || address == 0x4D)
> && (reg_config1 & 0x1F) == (man_id & 0x0F)
> && reg_convrate <= 0x09) {
> kind = max6657;
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Mark, please apply.
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix regression caused by typo in lm90.c
[not found] <20070726230422.2955.70451.sendpatchset@localhost.localdomain>
2007-07-27 8:07 ` [PATCH] Fix regression caused by typo in lm90.c Jean Delvare
@ 2007-07-27 12:24 ` Rainer Birkenmaier
1 sibling, 0 replies; 3+ messages in thread
From: Rainer Birkenmaier @ 2007-07-27 12:24 UTC (permalink / raw)
To: Guillaume Chazarain
Cc: Mark M. Hoffman, Jean Delvare, linux-kernel, lm-sensors
Hi,
my original patch for this didn't have that typo, however I had spelled
it in small letters instead of capital letters. So I guess, the typo
sneaked in while switching from small to capital letter.
Main message: I can confirm that it actually is a typo :)
have a great day
/Rainer
Am Freitag, den 27.07.2007, 01:04 +0200 schrieb Guillaume Chazarain:
> Hi,
>
> The commit http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=32c82a934759b2c9939c9e25865c2d7d1204b9e8
> broke lm90 for my (Asus V6VA) laptop.
>
> Before 2.6.23-rc1 and with the following patch, I get:
>
> [g ~]$ sensors
> max6657-i2c-0-4c
> Adapter: SMBus I801 adapter at 0400
> M/B Temp: +64°C (low = +0°C, high = +127°C)
> CPU Temp: +78.9°C (low = +73.2°C, high = +88.2°C)
> M/B Crit: +105°C (hyst = +95°C)
> CPU Crit: +105°C (hyst = +95°C)
>
> Which regressed into:
>
> [g ~]$ sensors
> No sensors found!
> Make sure you loaded all the kernel drivers you need.
> Try sensors-detect to find out which these are.
> zsh: 2701 exit 1 sensors
>
> and dmesg contains:
>
> i2c-adapter i2c-0: Unsupported chip (man_id=0x4D, chip_id=0x4D).
>
> It seems to be a typo, as address 0X4F is mentionned nowhere else in the file,
> and my chip is actually at 0x4C.
>
> Thanks.
>
> Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
> ---
>
> diff -r 4cad6fced1a8 drivers/hwmon/lm90.c
> --- a/drivers/hwmon/lm90.c Thu Jul 26 13:44:58 2007 -0700
> +++ b/drivers/hwmon/lm90.c Tue Jul 24 00:02:52 2007 +0200
> @@ -585,7 +585,7 @@ static int lm90_detect(struct i2c_adapte
> * those of the man_id register.
> */
> if (chip_id == man_id
> - && (address == 0x4F || address == 0x4D)
> + && (address == 0x4C || address == 0x4D)
> && (reg_config1 & 0x1F) == (man_id & 0x0F)
> && reg_convrate <= 0x09) {
> kind = max6657;
--
>>> SIEMENS AG - Corporate Technology (CT SE 2) <<<
>>> Dipl.-Inf. Rainer Birkenmaier <<<
>>> email: rainer.birkenmaier@siemens.com <<<
>>> phone: +49-89-636-53725 fax: +49-89-636-45450 <<<
Siemens Aktiengesellschaft: Vorsitzender des Aufsichtsrats: Gerhard Cromme
Vorstand: Peter Löscher, Vorsitzender; Johannes Feldmayer, Heinrich
Hiesinger, Joe Kaeser, Rudi Lamprecht, Eduardo Montes,
Jürgen Radomski, Erich R. Reinhardt, Hermann Requardt, Uriel J. Sharef,
Klaus Wucherer
Sitz der Gesellschaft: Berlin und München; Registergericht: Berlin
Charlottenburg, HRB 12300, München, HRB 6684
WEEE-Reg.-Nr. DE 23691322
^ permalink raw reply [flat|nested] 3+ messages in thread