From: "Rustad, Mark D" <mark.d.rustad@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Daly, Dan" <dan.daly@intel.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"MRustad@gmail.com" <MRustad@gmail.com>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support
Date: Tue, 27 Feb 2018 22:45:19 +0000 [thread overview]
Message-ID: <CABB6175-4FC3-4742-9C54-FCDEE3E5A608@intel.com> (raw)
In-Reply-To: <20180227.103502.2160088807348773566.davem@davemloft.net>
> On Feb 27, 2018, at 7:35 AM, David Miller <davem@davemloft.net> wrote:
>
> I don't like these helpers on many different levels.
<snip much embarrassment>
> So kill off pci_sriov_enable() helper completely, it is unnecessary,
> and rename the disable helper so that it says something meaningful to
> the reader.
Yes. Once pointed out, I completely agree with your comments and wish that I had seen those things myself.
> Thanks.
V3 was junk, but your comments apply to V4 as well, so please ignore it.
Thank you for your valuable review.
--
Mark Rustad, Networking Division, Intel Corporation
prev parent reply other threads:[~2018-02-27 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 3:19 [RFC PATCH V3] virtio_pci: Add SR-IOV support Mark Rustad
2018-02-27 15:35 ` David Miller
2018-02-27 22:45 ` Rustad, Mark D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABB6175-4FC3-4742-9C54-FCDEE3E5A608@intel.com \
--to=mark.d.rustad@intel.com \
--cc=MRustad@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=dan.daly@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox