* [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234
@ 2024-02-16 8:04 Petlozu Pravareshwar
2024-02-16 11:34 ` Thierry Reding
2024-02-16 11:36 ` Thierry Reding
0 siblings, 2 replies; 5+ messages in thread
From: Petlozu Pravareshwar @ 2024-02-16 8:04 UTC (permalink / raw)
To: thierry.reding, jonathanh, pshete, p.zabel, dmitry.osipenko,
ulf.hansson, kkartik, cai.huoqing, spatra, linux-tegra,
linux-kernel
Cc: petlozup
From: Prathamesh Shete <pshete@nvidia.com>
Add SD wake event for Tegra234 so that system can be woken up from
suspend when SD card hot-plug/unplug event is detected.
Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
---
drivers/soc/tegra/pmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 6dfcc7f50ece..dc4eab3191c2 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -3,7 +3,7 @@
* drivers/soc/tegra/pmc.c
*
* Copyright (c) 2010 Google, Inc
- * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
+ * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
*
* Author:
* Colin Cross <ccross@google.com>
@@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_events[] = {
TEGRA_WAKE_IRQ("pmu", 24, 209),
TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
+ TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
TEGRA_WAKE_IRQ("rtc", 73, 10),
TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179),
};
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234
2024-02-16 8:04 [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234 Petlozu Pravareshwar
@ 2024-02-16 11:34 ` Thierry Reding
2024-02-16 12:35 ` Petlozu Pravareshwar
2024-02-16 11:36 ` Thierry Reding
1 sibling, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2024-02-16 11:34 UTC (permalink / raw)
To: Petlozu Pravareshwar, jonathanh, pshete, p.zabel, dmitry.osipenko,
ulf.hansson, kkartik, cai.huoqing, spatra, linux-tegra,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]
On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> From: Prathamesh Shete <pshete@nvidia.com>
>
> Add SD wake event for Tegra234 so that system can be woken up from
> suspend when SD card hot-plug/unplug event is detected.
>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> ---
> drivers/soc/tegra/pmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 6dfcc7f50ece..dc4eab3191c2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
> * drivers/soc/tegra/pmc.c
> *
> * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> *
> * Author:
> * Colin Cross <ccross@google.com>
> @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_events[] = {
> TEGRA_WAKE_IRQ("pmu", 24, 209),
> TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
I'd prefer to stick with - instead of _ in these names, like we do with
sw-wake. No need to resend, I can make that change when applying,
provided you don't have any objections.
Thierry
> TEGRA_WAKE_IRQ("rtc", 73, 10),
> TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179),
> };
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234
2024-02-16 11:34 ` Thierry Reding
@ 2024-02-16 12:35 ` Petlozu Pravareshwar
0 siblings, 0 replies; 5+ messages in thread
From: Petlozu Pravareshwar @ 2024-02-16 12:35 UTC (permalink / raw)
To: Thierry Reding, Jon Hunter, Prathamesh Shete,
p.zabel@pengutronix.de, dmitry.osipenko@collabora.com,
ulf.hansson@linaro.org, Kartik Rajput, cai.huoqing@linux.dev,
Sandipan Patra, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
> On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> > From: Prathamesh Shete <pshete@nvidia.com>
> >
> > Add SD wake event for Tegra234 so that system can be woken up from
> > suspend when SD card hot-plug/unplug event is detected.
> >
> > Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> > Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> > ---
> > drivers/soc/tegra/pmc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index
> > 6dfcc7f50ece..dc4eab3191c2 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -3,7 +3,7 @@
> > * drivers/soc/tegra/pmc.c
> > *
> > * Copyright (c) 2010 Google, Inc
> > - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> > + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> > *
> > * Author:
> > * Colin Cross <ccross@google.com>
> > @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event
> tegra234_wake_events[] = {
> > TEGRA_WAKE_IRQ("pmu", 24, 209),
> > TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> > TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> > + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
>
> I'd prefer to stick with - instead of _ in these names, like we do with sw-wake.
> No need to resend, I can make that change when applying, provided you
> don't have any objections.
>
Yes, let's stick with - only instead of _ in the names for consistency.
Thanks.
> Thierry
>
> > TEGRA_WAKE_IRQ("rtc", 73, 10),
> > TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179), };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234
2024-02-16 8:04 [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234 Petlozu Pravareshwar
2024-02-16 11:34 ` Thierry Reding
@ 2024-02-16 11:36 ` Thierry Reding
2024-02-16 12:40 ` Petlozu Pravareshwar
1 sibling, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2024-02-16 11:36 UTC (permalink / raw)
To: Petlozu Pravareshwar, jonathanh, pshete, p.zabel, dmitry.osipenko,
ulf.hansson, kkartik, cai.huoqing, spatra, linux-tegra,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> From: Prathamesh Shete <pshete@nvidia.com>
>
> Add SD wake event for Tegra234 so that system can be woken up from
> suspend when SD card hot-plug/unplug event is detected.
>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> ---
> drivers/soc/tegra/pmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 6dfcc7f50ece..dc4eab3191c2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
> * drivers/soc/tegra/pmc.c
> *
> * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> *
> * Author:
> * Colin Cross <ccross@google.com>
> @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_events[] = {
> TEGRA_WAKE_IRQ("pmu", 24, 209),
> TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
These are also meant to be ordered by wake ID, so I've moved this up to
where it belongs.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234
2024-02-16 11:36 ` Thierry Reding
@ 2024-02-16 12:40 ` Petlozu Pravareshwar
0 siblings, 0 replies; 5+ messages in thread
From: Petlozu Pravareshwar @ 2024-02-16 12:40 UTC (permalink / raw)
To: Thierry Reding, Jon Hunter, Prathamesh Shete,
p.zabel@pengutronix.de, dmitry.osipenko@collabora.com,
ulf.hansson@linaro.org, Kartik Rajput, cai.huoqing@linux.dev,
Sandipan Patra, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
> On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> > From: Prathamesh Shete <pshete@nvidia.com>
> >
> > Add SD wake event for Tegra234 so that system can be woken up from
> > suspend when SD card hot-plug/unplug event is detected.
> >
> > Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> > Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> > ---
> > drivers/soc/tegra/pmc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index
> > 6dfcc7f50ece..dc4eab3191c2 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -3,7 +3,7 @@
> > * drivers/soc/tegra/pmc.c
> > *
> > * Copyright (c) 2010 Google, Inc
> > - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> > + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> > *
> > * Author:
> > * Colin Cross <ccross@google.com>
> > @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event
> tegra234_wake_events[] = {
> > TEGRA_WAKE_IRQ("pmu", 24, 209),
> > TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> > TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> > + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
>
> These are also meant to be ordered by wake ID, so I've moved this up to
> where it belongs.
>
> Thierry
Got it. Thanks for taking care of this.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-16 12:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-16 8:04 [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234 Petlozu Pravareshwar
2024-02-16 11:34 ` Thierry Reding
2024-02-16 12:35 ` Petlozu Pravareshwar
2024-02-16 11:36 ` Thierry Reding
2024-02-16 12:40 ` Petlozu Pravareshwar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox