From: "Jarkko Sakkinen" <jarkko.sakkinen@iki.fi>
To: "Richard Weinberger" <richard@sigma-star.at>,
"David Gstir" <david@sigma-star.at>,
"sigma star Kernel Team" <upstream+dcp@sigma-star.at>,
"James Bottomley" <James.Bottomley@hansenpartnership.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"David Howells" <dhowells@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"David Oberhollenzer" <david.oberhollenzer@sigma-star.at>,
"Richard Weinberger" <richard@nod.at>, <upstream@sigma-star.at>
Cc: <linux-integrity@vger.kernel.org>, <keyrings@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"kernel test robot" <lkp@intel.com>,
"Jarkko Sakkinen" <jarkko@kernel.org>
Subject: Re: [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment
Date: Wed, 17 Jul 2024 14:26:09 +0300 [thread overview]
Message-ID: <D2RRZWLG2VS6.200QD0IS373W2@iki.fi> (raw)
In-Reply-To: <2351895.22IY78Rhhi@somecomputer>
On Wed Jul 17, 2024 at 1:19 PM EEST, Richard Weinberger wrote:
> Am Mittwoch, 17. Juli 2024, 12:07:58 CEST schrieb Jarkko Sakkinen:
> > On Wed Jul 3, 2024 at 3:53 PM EEST, David Gstir wrote:
> > > The DCP trusted key type uses the wrong helper function to store
> > > the blob's payload length which can lead to the wrong byte order
> > > being used in case this would ever run on big endian architectures.
> > >
> > > Fix by using correct helper function.
> > >
> > > Signed-off-by: David Gstir <david@sigma-star.at>
> > > Suggested-by: Richard Weinberger <richard@nod.at>
> >
> > You cannot suggest a change that you author yourself.
>
> Well, I suggested the change, not David.
> So, I think you're implying that David's s-o-b cannot be before
> the Suggested-by tag but after?
I have dyslexia, I actually read it incorrectly so thanks
for pointing this ;-)
So keeping the tag is fine just reorder the tags, and the fix
will be fine.
Don't expect fast response, I'm on holiday still this and next
week. Just shuffling through inbox weekly basis.
BR, Jarkko
next prev parent reply other threads:[~2024-07-17 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:53 [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment David Gstir
2024-07-03 12:53 ` [PATCH 2/2] KEYS: trusted: dcp: fix leak of blob encryption key David Gstir
2024-07-17 10:32 ` Jarkko Sakkinen
2024-07-17 10:07 ` [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment Jarkko Sakkinen
2024-07-17 10:19 ` Richard Weinberger
2024-07-17 11:26 ` Jarkko Sakkinen [this message]
2024-07-17 11:03 ` David Gstir
2024-07-17 11:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2RRZWLG2VS6.200QD0IS373W2@iki.fi \
--to=jarkko.sakkinen@iki.fi \
--cc=James.Bottomley@hansenpartnership.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=david@sigma-star.at \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@paul-moore.com \
--cc=richard@nod.at \
--cc=richard@sigma-star.at \
--cc=serge@hallyn.com \
--cc=upstream+dcp@sigma-star.at \
--cc=upstream@sigma-star.at \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox