From: "Jarkko Sakkinen" <jarkko.sakkinen@iki.fi>
To: "David Gstir" <david@sigma-star.at>,
"Jarkko Sakkinen" <jarkko@kernel.org>
Cc: "sigma star Kernel Team" <upstream+dcp@sigma-star.at>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"David Howells" <dhowells@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"David Oberhollenzer" <david.oberhollenzer@sigma-star.at>,
"Richard Weinberger" <richard@nod.at>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment
Date: Wed, 17 Jul 2024 14:27:28 +0300 [thread overview]
Message-ID: <D2RS0WWX03O1.2BBRF131UTSXC@iki.fi> (raw)
In-Reply-To: <CE5319C4-F81F-4C70-AF74-B0B32DC60CCE@sigma-star.at>
On Wed Jul 17, 2024 at 2:03 PM EEST, David Gstir wrote:
> Jarkko,
>
> > On 17.07.2024, at 12:07, Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > On Wed Jul 3, 2024 at 3:53 PM EEST, David Gstir wrote:
> >> The DCP trusted key type uses the wrong helper function to store
> >> the blob's payload length which can lead to the wrong byte order
> >> being used in case this would ever run on big endian architectures.
> >>
> >> Fix by using correct helper function.
> >>
> >> Signed-off-by: David Gstir <david@sigma-star.at>
> >> Suggested-by: Richard Weinberger <richard@nod.at>
> >
> > You cannot suggest a change that you author yourself.
> >
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Closes: https://lore.kernel.org/oe-kbuild-all/202405240610.fj53EK0q-lkp@intel.com/
> >> Fixes: 2e8a0f40a39c ("KEYS: trusted: Introduce NXP DCP-backed trusted keys")
> >
> > Tags are in wrong order. For next round:
>
> here’s me relying on checkpatch.pl to tell me this, but it did not. :-/
> Anyways, thanks for reviewing! I’ll fix the tags and send v2.
Cool, might take over a week before response from my side but I'm sure
we get this to some rc of 6.11. I've purposely kept my 6.11 PR feature
free because the merge window was right in the middle of my holiday
:-)
BR, Jarkko
prev parent reply other threads:[~2024-07-17 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:53 [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment David Gstir
2024-07-03 12:53 ` [PATCH 2/2] KEYS: trusted: dcp: fix leak of blob encryption key David Gstir
2024-07-17 10:32 ` Jarkko Sakkinen
2024-07-17 10:07 ` [PATCH 1/2] KEYS: trusted: fix DCP blob payload length assignment Jarkko Sakkinen
2024-07-17 10:19 ` Richard Weinberger
2024-07-17 11:26 ` Jarkko Sakkinen
2024-07-17 11:03 ` David Gstir
2024-07-17 11:27 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2RS0WWX03O1.2BBRF131UTSXC@iki.fi \
--to=jarkko.sakkinen@iki.fi \
--cc=James.Bottomley@HansenPartnership.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=david@sigma-star.at \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paul@paul-moore.com \
--cc=richard@nod.at \
--cc=serge@hallyn.com \
--cc=upstream+dcp@sigma-star.at \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox