* [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
@ 2024-12-02 15:45 Luca Weiss
2024-12-02 20:00 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Luca Weiss @ 2024-12-02 15:45 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Luca Weiss
During an earlier commit, the comment from SM6350 was copied without
modifying. Adjust the comment to reflect the defines.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
include/dt-bindings/power/qcom-rpmpd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -65,7 +65,7 @@
#define SM6350_MSS 4
#define SM6350_MX 5
-/* SM6350 Power Domain Indexes */
+/* SM6375 Power Domain Indexes */
#define SM6375_VDDCX 0
#define SM6375_VDDCX_AO 1
#define SM6375_VDDCX_VFL 2
---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241202-rpmpd-sm6375-06582e126d7f
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-02 15:45 [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375 Luca Weiss
@ 2024-12-02 20:00 ` Dmitry Baryshkov
2024-12-03 7:52 ` Luca Weiss
2025-01-27 10:16 ` Luca Weiss
2025-02-04 14:40 ` Ulf Hansson
2 siblings, 1 reply; 9+ messages in thread
From: Dmitry Baryshkov @ 2024-12-02 20:00 UTC (permalink / raw)
To: Luca Weiss
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On Mon, Dec 02, 2024 at 04:45:02PM +0100, Luca Weiss wrote:
> During an earlier commit, the comment from SM6350 was copied without
> modifying. Adjust the comment to reflect the defines.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Fixes tag, please.
> ---
> include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -65,7 +65,7 @@
> #define SM6350_MSS 4
> #define SM6350_MX 5
>
> -/* SM6350 Power Domain Indexes */
> +/* SM6375 Power Domain Indexes */
> #define SM6375_VDDCX 0
> #define SM6375_VDDCX_AO 1
> #define SM6375_VDDCX_VFL 2
>
> ---
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> change-id: 20241202-rpmpd-sm6375-06582e126d7f
>
> Best regards,
> --
> Luca Weiss <luca.weiss@fairphone.com>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-02 20:00 ` Dmitry Baryshkov
@ 2024-12-03 7:52 ` Luca Weiss
2024-12-03 12:58 ` Marijn Suijten
2024-12-03 13:57 ` Dmitry Baryshkov
0 siblings, 2 replies; 9+ messages in thread
From: Luca Weiss @ 2024-12-03 7:52 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On Mon Dec 2, 2024 at 9:00 PM CET, Dmitry Baryshkov wrote:
> On Mon, Dec 02, 2024 at 04:45:02PM +0100, Luca Weiss wrote:
> > During an earlier commit, the comment from SM6350 was copied without
> > modifying. Adjust the comment to reflect the defines.
> >
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>
> Fixes tag, please.
I thought for just a comment fix it's not necessary / desired.
Anyways:
Fixes: 2d48e6ea3080 ("dt-bindings: power: rpmpd: Add SM6375 power domains")
>
> > ---
> > include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> > index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> > --- a/include/dt-bindings/power/qcom-rpmpd.h
> > +++ b/include/dt-bindings/power/qcom-rpmpd.h
> > @@ -65,7 +65,7 @@
> > #define SM6350_MSS 4
> > #define SM6350_MX 5
> >
> > -/* SM6350 Power Domain Indexes */
> > +/* SM6375 Power Domain Indexes */
> > #define SM6375_VDDCX 0
> > #define SM6375_VDDCX_AO 1
> > #define SM6375_VDDCX_VFL 2
> >
> > ---
> > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> > change-id: 20241202-rpmpd-sm6375-06582e126d7f
> >
> > Best regards,
> > --
> > Luca Weiss <luca.weiss@fairphone.com>
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-03 7:52 ` Luca Weiss
@ 2024-12-03 12:58 ` Marijn Suijten
2024-12-03 13:04 ` Marijn Suijten
2024-12-03 13:57 ` Dmitry Baryshkov
1 sibling, 1 reply; 9+ messages in thread
From: Marijn Suijten @ 2024-12-03 12:58 UTC (permalink / raw)
To: Luca Weiss
Cc: Dmitry Baryshkov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On 2024-12-03 08:52:59, Luca Weiss wrote:
> On Mon Dec 2, 2024 at 9:00 PM CET, Dmitry Baryshkov wrote:
> > On Mon, Dec 02, 2024 at 04:45:02PM +0100, Luca Weiss wrote:
> > > During an earlier commit, the comment from SM6350 was copied without
> > > modifying. Adjust the comment to reflect the defines.
> > >
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> >
> > Fixes tag, please.
>
> I thought for just a comment fix it's not necessary / desired.
Makes one wonder why the SoC name is repeated in a comment in the first place,
when it is already in every named constant and the containing filename too.
That's only prone to errors as you've demonstrated here, requiring a separate
commit and discussion (and automatic backporting via Fixes:) to patch up, while
it already wasn't relevant/useful for anyone.
Less is more.
- Marijn
PS: That's a suggestion to see if we can perhaps remove these from all header
files instead to save the copy-paste burden in the future?
>
> Anyways:
>
> Fixes: 2d48e6ea3080 ("dt-bindings: power: rpmpd: Add SM6375 power domains")
>
>
> >
> > > ---
> > > include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> > > index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> > > --- a/include/dt-bindings/power/qcom-rpmpd.h
> > > +++ b/include/dt-bindings/power/qcom-rpmpd.h
> > > @@ -65,7 +65,7 @@
> > > #define SM6350_MSS 4
> > > #define SM6350_MX 5
> > >
> > > -/* SM6350 Power Domain Indexes */
> > > +/* SM6375 Power Domain Indexes */
> > > #define SM6375_VDDCX 0
> > > #define SM6375_VDDCX_AO 1
> > > #define SM6375_VDDCX_VFL 2
> > >
> > > ---
> > > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> > > change-id: 20241202-rpmpd-sm6375-06582e126d7f
> > >
> > > Best regards,
> > > --
> > > Luca Weiss <luca.weiss@fairphone.com>
> > >
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-03 12:58 ` Marijn Suijten
@ 2024-12-03 13:04 ` Marijn Suijten
0 siblings, 0 replies; 9+ messages in thread
From: Marijn Suijten @ 2024-12-03 13:04 UTC (permalink / raw)
To: Luca Weiss, Dmitry Baryshkov, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, ~postmarketos/upstreaming, phone-devel,
linux-arm-msm, devicetree, linux-kernel
On 2024-12-03 13:58:51, Marijn Suijten wrote:
> On 2024-12-03 08:52:59, Luca Weiss wrote:
> > On Mon Dec 2, 2024 at 9:00 PM CET, Dmitry Baryshkov wrote:
> > > On Mon, Dec 02, 2024 at 04:45:02PM +0100, Luca Weiss wrote:
> > > > During an earlier commit, the comment from SM6350 was copied without
> > > > modifying. Adjust the comment to reflect the defines.
> > > >
> > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > >
> > > Fixes tag, please.
> >
> > I thought for just a comment fix it's not necessary / desired.
>
> Makes one wonder why the SoC name is repeated in a comment in the first place,
> when it is already in every named constant and the containing filename too.
> That's only prone to errors as you've demonstrated here, requiring a separate
> commit and discussion (and automatic backporting via Fixes:) to patch up, while
> it already wasn't relevant/useful for anyone.
Never mind, the filename isn't different, I glanced over too quickly.
In that case the repeat is still somewhat relevant as a separator between all
the SoC-specific defines in this file, even if the #define repeats it as well?
Apologies for the noise.
>
> Less is more.
>
> - Marijn
>
> PS: That's a suggestion to see if we can perhaps remove these from all header
> files instead to save the copy-paste burden in the future?
>
> >
> > Anyways:
> >
> > Fixes: 2d48e6ea3080 ("dt-bindings: power: rpmpd: Add SM6375 power domains")
> >
> >
> > >
> > > > ---
> > > > include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> > > > index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> > > > --- a/include/dt-bindings/power/qcom-rpmpd.h
> > > > +++ b/include/dt-bindings/power/qcom-rpmpd.h
> > > > @@ -65,7 +65,7 @@
> > > > #define SM6350_MSS 4
> > > > #define SM6350_MX 5
> > > >
> > > > -/* SM6350 Power Domain Indexes */
> > > > +/* SM6375 Power Domain Indexes */
> > > > #define SM6375_VDDCX 0
> > > > #define SM6375_VDDCX_AO 1
> > > > #define SM6375_VDDCX_VFL 2
> > > >
> > > > ---
> > > > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> > > > change-id: 20241202-rpmpd-sm6375-06582e126d7f
> > > >
> > > > Best regards,
> > > > --
> > > > Luca Weiss <luca.weiss@fairphone.com>
> > > >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-03 7:52 ` Luca Weiss
2024-12-03 12:58 ` Marijn Suijten
@ 2024-12-03 13:57 ` Dmitry Baryshkov
1 sibling, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2024-12-03 13:57 UTC (permalink / raw)
To: Luca Weiss
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On Tue, Dec 03, 2024 at 08:52:59AM +0100, Luca Weiss wrote:
> On Mon Dec 2, 2024 at 9:00 PM CET, Dmitry Baryshkov wrote:
> > On Mon, Dec 02, 2024 at 04:45:02PM +0100, Luca Weiss wrote:
> > > During an earlier commit, the comment from SM6350 was copied without
> > > modifying. Adjust the comment to reflect the defines.
> > >
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> >
> > Fixes tag, please.
>
> I thought for just a comment fix it's not necessary / desired.
>
> Anyways:
>
> Fixes: 2d48e6ea3080 ("dt-bindings: power: rpmpd: Add SM6375 power domains")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-02 15:45 [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375 Luca Weiss
2024-12-02 20:00 ` Dmitry Baryshkov
@ 2025-01-27 10:16 ` Luca Weiss
2025-01-28 10:40 ` Ulf Hansson
2025-02-04 14:40 ` Ulf Hansson
2 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2025-01-27 10:16 UTC (permalink / raw)
To: Luca Weiss, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ulf Hansson
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On Mon Dec 2, 2024 at 4:45 PM CET, Luca Weiss wrote:
> During an earlier commit, the comment from SM6350 was copied without
> modifying. Adjust the comment to reflect the defines.
Ping, could this trivial patch be picked up please?
Regards
Luca
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -65,7 +65,7 @@
> #define SM6350_MSS 4
> #define SM6350_MX 5
>
> -/* SM6350 Power Domain Indexes */
> +/* SM6375 Power Domain Indexes */
> #define SM6375_VDDCX 0
> #define SM6375_VDDCX_AO 1
> #define SM6375_VDDCX_VFL 2
>
> ---
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> change-id: 20241202-rpmpd-sm6375-06582e126d7f
>
> Best regards,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2025-01-27 10:16 ` Luca Weiss
@ 2025-01-28 10:40 ` Ulf Hansson
0 siblings, 0 replies; 9+ messages in thread
From: Ulf Hansson @ 2025-01-28 10:40 UTC (permalink / raw)
To: Luca Weiss
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On Mon, 27 Jan 2025 at 11:16, Luca Weiss <luca.weiss@fairphone.com> wrote:
>
> On Mon Dec 2, 2024 at 4:45 PM CET, Luca Weiss wrote:
> > During an earlier commit, the comment from SM6350 was copied without
> > modifying. Adjust the comment to reflect the defines.
>
> Ping, could this trivial patch be picked up please?
I pick it up after the merge window closes, via my pmdomain tree.
Kind regards
Uffe
>
> Regards
> Luca
>
> >
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> > include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> > index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> > --- a/include/dt-bindings/power/qcom-rpmpd.h
> > +++ b/include/dt-bindings/power/qcom-rpmpd.h
> > @@ -65,7 +65,7 @@
> > #define SM6350_MSS 4
> > #define SM6350_MX 5
> >
> > -/* SM6350 Power Domain Indexes */
> > +/* SM6375 Power Domain Indexes */
> > #define SM6375_VDDCX 0
> > #define SM6375_VDDCX_AO 1
> > #define SM6375_VDDCX_VFL 2
> >
> > ---
> > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> > change-id: 20241202-rpmpd-sm6375-06582e126d7f
> >
> > Best regards,
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375
2024-12-02 15:45 [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375 Luca Weiss
2024-12-02 20:00 ` Dmitry Baryshkov
2025-01-27 10:16 ` Luca Weiss
@ 2025-02-04 14:40 ` Ulf Hansson
2 siblings, 0 replies; 9+ messages in thread
From: Ulf Hansson @ 2025-02-04 14:40 UTC (permalink / raw)
To: Luca Weiss
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
On Mon, 2 Dec 2024 at 17:25, Luca Weiss <luca.weiss@fairphone.com> wrote:
>
> During an earlier commit, the comment from SM6350 was copied without
> modifying. Adjust the comment to reflect the defines.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> include/dt-bindings/power/qcom-rpmpd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index df599bf462207267a412eac8e01634189a696a59..d9b7bac309537cbfd2488e7d4fe21d195c919ef5 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -65,7 +65,7 @@
> #define SM6350_MSS 4
> #define SM6350_MX 5
>
> -/* SM6350 Power Domain Indexes */
> +/* SM6375 Power Domain Indexes */
> #define SM6375_VDDCX 0
> #define SM6375_VDDCX_AO 1
> #define SM6375_VDDCX_VFL 2
>
> ---
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> change-id: 20241202-rpmpd-sm6375-06582e126d7f
>
> Best regards,
> --
> Luca Weiss <luca.weiss@fairphone.com>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-02-04 14:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 15:45 [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375 Luca Weiss
2024-12-02 20:00 ` Dmitry Baryshkov
2024-12-03 7:52 ` Luca Weiss
2024-12-03 12:58 ` Marijn Suijten
2024-12-03 13:04 ` Marijn Suijten
2024-12-03 13:57 ` Dmitry Baryshkov
2025-01-27 10:16 ` Luca Weiss
2025-01-28 10:40 ` Ulf Hansson
2025-02-04 14:40 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox