public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: "Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Rishi Gupta" <gupt21@gmail.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 3/4] iio: gts-helper: export iio_gts_get_total_gain()
Date: Sat, 25 Jan 2025 21:08:51 +0100	[thread overview]
Message-ID: <D7BFCPQPV9W0.1C7B7VU5Y4FCL@gmail.com> (raw)
In-Reply-To: <9bdd3a1d-0eb3-4ef1-a6b8-f613de1eecb4@gmail.com>

On Fri Jan 24, 2025 at 9:12 AM CET, Matti Vaittinen wrote:
> On 19/01/2025 19:32, Javier Carrasco wrote:
> > Export this function in preparation for the fix in veml6030.c, where the
> > total gain can be used to ease the calculation of the processed value of
> > the IIO_LIGHT channel compared to acquiring the scale in NANO.
> >
> > Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>
> Hi Javier,
>
> This is fine but could you please go the extra mile and add a doc to the
> function? I'd like to have kerneldoc for all exported functions.
>

Hi Matti,

Sure, I will add that for v3.

Thanks for your feedback and best regards,
Javier Carrasco

  reply	other threads:[~2025-01-25 20:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-19 17:31 [PATCH v2 0/4] iio: light: fix scale in veml6030 Javier Carrasco
2025-01-19 17:31 ` [PATCH v2 1/4] iio: light: veml6030: extend regmap to support regfields Javier Carrasco
2025-01-19 17:31 ` [PATCH v2 2/4] iio: light: veml6030: extend regmap to support caching Javier Carrasco
2025-01-19 17:32 ` [PATCH v2 3/4] iio: gts-helper: export iio_gts_get_total_gain() Javier Carrasco
2025-01-24  8:12   ` Matti Vaittinen
2025-01-25 20:08     ` Javier Carrasco [this message]
2025-01-19 17:32 ` [PATCH v2 4/4] iio: light: veml6030: fix scale to conform to ABI Javier Carrasco
2025-01-24  8:24   ` Matti Vaittinen
2025-01-25 12:33 ` [PATCH v2 0/4] iio: light: fix scale in veml6030 Jonathan Cameron
2025-01-25 20:12   ` Javier Carrasco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D7BFCPQPV9W0.1C7B7VU5Y4FCL@gmail.com \
    --to=javier.carrasco.cruz@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=gupt21@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox