From: "Michael Walle" <mwalle@kernel.org>
To: "Cheng Ming Lin" <linchengming884@gmail.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Cheng Ming Lin" <chengminglin@mxic.com.tw>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<alvinzhou@mxic.com.tw>, <leoyu@mxic.com.tw>,
"Maarten Zanders" <maarten@zanders.be>
Subject: Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields
Date: Wed, 24 Sep 2025 14:10:56 +0200 [thread overview]
Message-ID: <DD10QMSJVZ2K.26U45JAXV5EY7@kernel.org> (raw)
In-Reply-To: <CAAyq3SYybDgBvkTKh2ZB4UdKq1XV_nnzx3Tj1P915W5x_7_nNA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
> The root cause of this problem lies in the failure of parsing the SFDP
> data for the flash, rather than an issue with the patch itself. I believe
> we should not revert this patch.
I disagree. There are Macronix flashes with that ID which doesn't
have SFDP. And this patch is dropping support for them. See also
[1]. Now I'm not sure it is worth reverting this commit. Nobody,
except Guenter complained, but only *so far* (and that patch is in
since 6.16). Any opinions?
-michael
[1] https://lore.kernel.org/r/DD10GE4EOCD7.CPTN7198QFUV@kernel.org/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
next prev parent reply other threads:[~2025-09-24 12:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:53 [PATCH v2 0/3] mtd: spi-nor: macronix: Cleanup macronix flash info Cheng Ming Lin
2025-04-07 7:53 ` [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields Cheng Ming Lin
2025-06-08 1:04 ` Guenter Roeck
2025-06-08 12:53 ` Pratyush Yadav
2025-06-09 1:13 ` Guenter Roeck
2025-06-10 0:14 ` Guenter Roeck
2025-06-10 6:46 ` Tudor Ambarus
2025-06-10 7:29 ` Cheng Ming Lin
2025-06-10 7:43 ` Guenter Roeck
2025-09-24 12:10 ` Michael Walle [this message]
2025-09-30 7:36 ` Cheng Ming Lin
2025-09-30 12:19 ` Pratyush Yadav
2025-09-30 13:15 ` Maarten Zanders
2025-10-01 6:59 ` Michael Walle
2025-09-30 14:39 ` Guenter Roeck
2025-06-10 7:41 ` Guenter Roeck
2025-06-22 19:09 ` Pratyush Yadav
2025-10-01 9:35 ` Cédric Le Goater
2025-04-07 7:53 ` [PATCH v2 2/3] mtd: spi-nor: macronix: Remove duplicate flash info entries Cheng Ming Lin
2025-04-07 7:54 ` [PATCH v2 3/3] mtd: spi-nor: macronix: Add fixups for MX25L3255E Cheng Ming Lin
2025-04-07 8:25 ` Cheng Ming Lin
2025-04-08 14:52 ` Pratyush Yadav
2025-05-06 9:36 ` [PATCH v2 0/3] mtd: spi-nor: macronix: Cleanup macronix flash info Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD10QMSJVZ2K.26U45JAXV5EY7@kernel.org \
--to=mwalle@kernel.org \
--cc=alvinzhou@mxic.com.tw \
--cc=chengminglin@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linchengming884@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=maarten@zanders.be \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox